RESOLVED FIXED 97076
[BlackBerry] Empty URL gets through to acceptNavigationRequest() 
https://bugs.webkit.org/show_bug.cgi?id=97076
Summary [BlackBerry] Empty URL gets through to acceptNavigationRequest()
Charles Wei
Reported 2012-09-18 23:38:08 PDT
Internal PR: 205008 invalid URL will result in an empty URL in platform request, we should stop loading of an empty URL.
Attachments
Patch (3.60 KB, patch)
2012-09-19 00:03 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-09-19 00:03:19 PDT
Created attachment 164674 [details] Patch
George Staikos
Comment 2 2012-09-25 23:01:09 PDT
Comment on attachment 164674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164674&action=review r- to make the diff smaller. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:221 > + if (!platformRequest.getUrlRef().empty()) { // Some invalid URLs will result in empty URL in platformRequest Let's make this an early return instead?
Charles Wei
Comment 3 2012-09-26 00:30:20 PDT
Comment on attachment 164674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164674&action=review >> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:221 >> + if (!platformRequest.getUrlRef().empty()) { // Some invalid URLs will result in empty URL in platformRequest > > Let's make this an early return instead? We should not early return. look at the last several lines of this block, we should go there to call : dispatchDidCancelClientRedirect(), policyChecker()->*function)(decision), didDecidePolicyForNavigationAction(action, request) to do some clean up work no matter what the decision is. So I don't think we should do an early return here.
Charles Wei
Comment 4 2012-09-26 00:31:11 PDT
Comment on attachment 164674 [details] Patch Re-raise the review flag since I don't agree with the reviewer's comments, which seems wrong.
George Staikos
Comment 5 2012-09-27 22:22:04 PDT
Comment on attachment 164674 [details] Patch right.
WebKit Review Bot
Comment 6 2012-09-27 23:09:48 PDT
Comment on attachment 164674 [details] Patch Clearing flags on attachment: 164674 Committed r129853: <http://trac.webkit.org/changeset/129853>
WebKit Review Bot
Comment 7 2012-09-27 23:09:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.