Bug 97070 - [BlackBerry] remove static_cast which will cause video crash
Summary: [BlackBerry] remove static_cast which will cause video crash
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Dong
Depends on:
Reported: 2012-09-18 22:38 PDT by Jonathan Dong
Modified: 2012-09-19 07:11 PDT (History)
8 users (show)

See Also:

Patch (2.58 KB, patch)
2012-09-18 22:56 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-09-18 22:38:13 PDT
RIM PR: 187543

In some cases (e.g. test case media/video-size.html) we haven't had a chance to call load() to create a real media player before we use it, so the MediaPlayer->m_private is still pointing to a NullMediaPlayerPrivate, but we use static_cast to cast it to a (BlackBerry)MediaPlayerPrivate. This is a layering violation and will cause a runtime crash.
Comment 1 Jonathan Dong 2012-09-18 22:56:55 PDT
Created attachment 164665 [details]
Comment 2 WebKit Review Bot 2012-09-19 07:11:25 PDT
Comment on attachment 164665 [details]

Clearing flags on attachment: 164665

Committed r129001: <http://trac.webkit.org/changeset/129001>
Comment 3 WebKit Review Bot 2012-09-19 07:11:28 PDT
All reviewed patches have been landed.  Closing bug.