Bug 97068 - [Chromium] Don't treat tab as spaces for word-end in HarfBuzzShaper
Summary: [Chromium] Don't treat tab as spaces for word-end in HarfBuzzShaper
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 21:46 PDT by Kenichi Ishibashi
Modified: 2012-09-19 10:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2012-09-18 21:52 PDT, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-09-18 21:46:21 PDT
On harfbuzz-ng enabled chromium linux, fast/text/wide-zero-width-space.html is failing. We can fix it by not treating tab as spaces, like https://bugs.webkit.org/show_bug.cgi?id=94010.
Comment 1 Kenichi Ishibashi 2012-09-18 21:52:27 PDT
Created attachment 164657 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-09-18 22:00:33 PDT
Yuta-san, Could you rubber-stamp?
Comment 3 Yuta Kitamura 2012-09-18 22:08:54 PDT
Comment on attachment 164657 [details]
Patch

Looks legit.
Comment 4 Kenichi Ishibashi 2012-09-18 22:11:25 PDT
Comment on attachment 164657 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-09-18 22:25:53 PDT
Comment on attachment 164657 [details]
Patch

Clearing flags on attachment: 164657

Committed r128965: <http://trac.webkit.org/changeset/128965>
Comment 6 WebKit Review Bot 2012-09-18 22:25:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Tony Chang 2012-09-19 10:12:33 PDT
Comment on attachment 164657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164657&action=review

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:158
> +        // Don't normalize tabs as they are not treated as spaces for word-end

Nit: Please end comments with a period.