RESOLVED FIXED 97067
[Chromium] SkiaGetGlyphWidthAndExtents() should invert y-axis 
https://bugs.webkit.org/show_bug.cgi?id=97067
Summary [Chromium] SkiaGetGlyphWidthAndExtents() should invert y-axis
Kenichi Ishibashi
Reported 2012-09-18 21:34:52 PDT
Skia is y-grows-down, while harfbuzz is set up with y-grows-up when we set scale positive. We also don't need to call hb_font_set_ppem(). hb-view() don't call it.
Attachments
Patch (2.61 KB, patch)
2012-09-18 22:09 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Added comment (2.72 KB, patch)
2012-09-18 22:47 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-09-18 22:09:42 PDT
Created attachment 164658 [details] Patch
Kenichi Ishibashi
Comment 2 2012-09-18 22:10:57 PDT
Yuta-san, could you rubber-stamp? behdad@ did informal review for this patch.
Yuta Kitamura
Comment 3 2012-09-18 22:27:02 PDT
Comment on attachment 164658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164658&action=review Code change looks fine. r- for lack of comments for non-obvious code. > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:72 > + extents->y_bearing = SkiaScalarToHarfbuzzPosition(-skBounds.fTop); I would like some comments explaining these nagations. Looks hard to understand.
Kenichi Ishibashi
Comment 4 2012-09-18 22:47:46 PDT
Created attachment 164663 [details] Added comment
Kenichi Ishibashi
Comment 5 2012-09-18 22:48:20 PDT
Comment on attachment 164658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164658&action=review Thank you for review! >> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:72 >> + extents->y_bearing = SkiaScalarToHarfbuzzPosition(-skBounds.fTop); > > I would like some comments explaining these nagations. Looks hard to understand. Done.
Yuta Kitamura
Comment 6 2012-09-18 22:48:51 PDT
Comment on attachment 164663 [details] Added comment OK.
Kenichi Ishibashi
Comment 7 2012-09-18 22:51:48 PDT
Comment on attachment 164663 [details] Added comment Thanks!
WebKit Review Bot
Comment 8 2012-09-18 23:19:08 PDT
Comment on attachment 164663 [details] Added comment Clearing flags on attachment: 164663 Committed r128968: <http://trac.webkit.org/changeset/128968>
WebKit Review Bot
Comment 9 2012-09-18 23:19:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.