Bug 97061 - [EFL][WK2] Add log macros for EINA_LOG_DOM_XXX series
Summary: [EFL][WK2] Add log macros for EINA_LOG_DOM_XXX series
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 19:37 PDT by Jinwoo Song
Modified: 2012-09-18 20:33 PDT (History)
5 users (show)

See Also:


Attachments
patch (3.31 KB, patch)
2012-09-18 19:39 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff
patch (3.46 KB, patch)
2012-09-18 19:45 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2012-09-18 19:37:23 PDT
EFL Webkit2 is using the EINA_LOG_DOM_XXX series in several places to log a message on the specified domain and format.
This patch adds log macros to simplify these logging codes.
Comment 1 Jinwoo Song 2012-09-18 19:39:53 PDT
Created attachment 164644 [details]
patch
Comment 2 Jinwoo Song 2012-09-18 19:45:45 PDT
Created attachment 164646 [details]
patch

include ewk_private.h in the ewk_main.cpp
Comment 3 Gyuyoung Kim 2012-09-18 19:56:21 PDT
Comment on attachment 164646 [details]
patch

Looks good to me. Could you notify this macro usage to webkit-efl mailing list after landing this patch ?
Comment 4 Kangil Han 2012-09-18 20:02:23 PDT
Looks neat. Thanks!
Comment 5 Jinwoo Song 2012-09-18 20:23:26 PDT
(In reply to comment #3)
> (From update of attachment 164646 [details])
> Looks good to me. Could you notify this macro usage to webkit-efl mailing list after landing this patch ?

Sure, I'll do it.
Comment 6 WebKit Review Bot 2012-09-18 20:33:13 PDT
Comment on attachment 164646 [details]
patch

Clearing flags on attachment: 164646

Committed r128962: <http://trac.webkit.org/changeset/128962>
Comment 7 WebKit Review Bot 2012-09-18 20:33:17 PDT
All reviewed patches have been landed.  Closing bug.