Bug 97060 - [V8] Remove WorkerContextExecutionProxy::runScript()
Summary: [V8] Remove WorkerContextExecutionProxy::runScript()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 97057
  Show dependency tree / graph
 
Reported: 2012-09-18 19:28 PDT by Kentaro Hara
Modified: 2012-09-19 17:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.17 KB, patch)
2012-09-18 19:40 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-09-18 19:28:54 PDT 
To kill WorkerContextExecutionProxy, we can remove WorkerContextExecutionProxy::runScript().
Comment 1 Kentaro Hara 2012-09-18 19:40:30 PDT 
Created attachment 164645 [details]
Patch
Comment 2 Adam Barth 2012-09-19 11:31:15 PDT 
Comment on attachment 164645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review

> Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274
> -    if (script.IsEmpty())
> -        return v8::Local<v8::Value>();

This check is missing from ScriptRunner::runCompiledScript.  I guess its not needed?
Comment 3 WebKit Review Bot 2012-09-19 11:51:56 PDT 
Comment on attachment 164645 [details]
Patch

Clearing flags on attachment: 164645

Committed r129026: <http://trac.webkit.org/changeset/129026>
Comment 4 WebKit Review Bot 2012-09-19 11:52:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Kentaro Hara 2012-09-19 17:08:45 PDT 
Comment on attachment 164645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review

>> Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274
>> -        return v8::Local<v8::Value>();
> 
> This check is missing from ScriptRunner::runCompiledScript.  I guess its not needed?

It's not needed in ScriptRunner::runCompiledScript, but was needed in WorkerContextExecutionProxy::runScript (because line 267 can generate an empty script).