Bug 97056 – Web Inspector: Modifications in a shadow tree don't update the Elements panel.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Kent Tamura]

1. Enable Developer Tools experiments in Google Chrome 23.0.1270.0
2. Open data:text/html,<input type=search>
3. Right click on the search field, and select "Inspect Element"
4. Expand child nodes of <input type=search> in the Elements panel.  It will show:

▼<input type="search">
  ▼#shadow-root
    ▼<div>
        <div></div>
      ▼<div>
          <div></div>  …(A)
        </div>
        <div></div>
      </div>
  </input>

5. Type something into the search field

Expected:
 (A) in the Elements panel should be updated for something typed in the step 5.

Actual:
 (A) keeps empty.

[Keishi Hattori]

Created attachment 165353 [details]
Patch

[Pavel Feldman]

Comment on attachment 165353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165353&action=review

> LayoutTests/inspector/elements/shadow-dom-modify-chardata.html:38
> +            function callback() {

{ should go on the next line.

> LayoutTests/inspector/elements/shadow-dom-modify-chardata.html:42
> +            function callback2() {

ditto

[Keishi Hattori]

Created attachment 165744 [details]
Patch

[Keishi Hattori]

(In reply to comment #2)
> (From update of attachment 165353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165353&action=review
> 
> > LayoutTests/inspector/elements/shadow-dom-modify-chardata.html:38
> > +            function callback() {
> 
> { should go on the next line.
Done.
> > LayoutTests/inspector/elements/shadow-dom-modify-chardata.html:42
> > +            function callback2() {
> 
> ditto
Done.

[WebKit Review Bot]

Comment on attachment 165744 [details]
Patch

Clearing flags on attachment: 165744

Committed r130004: <http://trac.webkit.org/changeset/130004>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Vsevolod Vlasov]

The new test is failing locally for me:

@@ -5,18 +5,12 @@
 Running: testDumpInitial
 ========= Original ========
 - <div id="container">
-    - <input type="text" id="input1">
-        - #shadow-root
-          <div></div>
-      </input>
+      <input type="text" id="input1">
   </div>
 
 Running: testAppend
 ======== Type text =========
 - <div id="container">
-    - <input type="text" id="input1">
-        - #shadow-root
-        + <div>Bar</div>
-      </input>
+      <input type="text" id="input1">
   </div>

[WebKit Review Bot]

Re-opened since this is blocked by bug 97996

[Keishi Hattori]

Somehow just failing on Windows and Linux. 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Felements%2Fshadow-dom-modify-chardata.html

[Keishi Hattori]

(In reply to comment #9)
> Somehow just failing on Windows and Linux. 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Felements%2Fshadow-dom-modify-chardata.html

Ah, we don't support inspector tests on Mac.

[Keishi Hattori]

Created attachment 166421 [details]
Patch

[Keishi Hattori]

showShadowDOM graduated experimental (http://trac.webkit.org/changeset/129861) so changed test.

[WebKit Review Bot]

Comment on attachment 166421 [details]
Patch

Clearing flags on attachment: 166421

Committed r130139: <http://trac.webkit.org/changeset/130139>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.