Bug 97047 - NRWT crashes on too many timeouts
Summary: NRWT crashes on too many timeouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords: NRWT
Depends on:
Blocks:
 
Reported: 2012-09-18 14:47 PDT by Don Olmstead
Modified: 2012-10-10 10:30 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.46 KB, patch)
2012-10-09 17:12 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2012-09-18 14:47:22 PDT 
NRWT crashes with an OSError, [Errno 24] Too many open files, if there were too many timeouts.

Full stack trace at https://gist.github.com/3746082

Steps to recreate
- Modify MockDRT in mock_drt.py to infinite loop in run.
    def run(self):
        while True:
            i = 1

- Run new-run-webkit-tests --platform=mock-chromium --no-build
Comment 1 Simon Fraser (smfr) 2012-09-21 11:33:35 PDT 
I tried to reproduce this, and wasn't able to easily do so. Mountain Lion. I was using 'lsof' to list open files, and did not see the list of open files increasing as the tests timed out.

 12$ $ python --version
Python 2.7.2
Comment 2 Don Olmstead 2012-09-21 12:50:01 PDT 
The OSError was encountered on Linux. Ubuntu 11.04 using Python 2.7.1+

Going to give it a go on Windows 7 x64 using Python 2.7.2.
Comment 3 Don Olmstead 2012-09-21 17:21:39 PDT 
Didn't see the OSError under Windows, but the processes we're still present in Task Manager.
Comment 4 Dirk Pranke 2012-10-09 17:12:49 PDT 
Created attachment 167878 [details]
Patch
Comment 5 Dirk Pranke 2012-10-09 17:20:35 PDT 
This did reproduce on Chromium LInux for me ...
Comment 6 Ojan Vafai 2012-10-09 19:00:44 PDT 
Looks fine to me. Tony, WDYT?
Comment 7 WebKit Review Bot 2012-10-10 10:30:51 PDT 
Comment on attachment 167878 [details]
Patch

Clearing flags on attachment: 167878

Committed r130922: <http://trac.webkit.org/changeset/130922>
Comment 8 WebKit Review Bot 2012-10-10 10:30:55 PDT 
All reviewed patches have been landed.  Closing bug.