Bug 97033 - [BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
Summary: [BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 11:38 PDT by Nima Ghanavatian
Modified: 2012-09-18 14:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.17 KB, patch)
2012-09-18 11:43 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (12.67 KB, patch)
2012-09-18 12:43 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-09-18 11:38:14 PDT 
SSIA
Comment 1 Nima Ghanavatian 2012-09-18 11:43:00 PDT 
Created attachment 164595 [details]
Patch
Comment 2 Rob Buis 2012-09-18 11:57:19 PDT 
Comment on attachment 164595 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-09-18 11:59:02 PDT 
Comment on attachment 164595 [details]
Patch

Rejecting attachment 164595 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
lines).
Hunk #5 FAILED at 663.
2 out of 5 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp.rej
patching file Source/WebKit/blackberry/WebKitSupport/InputHandler.h
Hunk #1 succeeded at 137 (offset 3 lines).
Hunk #2 succeeded at 197 (offset 3 lines).
Hunk #3 succeeded at 219 (offset 3 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/13895268
Comment 4 Nima Ghanavatian 2012-09-18 12:43:02 PDT 
rebasing and trying again...
Comment 5 Nima Ghanavatian 2012-09-18 12:43:10 PDT 
Created attachment 164603 [details]
Patch
Comment 6 Rob Buis 2012-09-18 12:54:16 PDT 
Comment on attachment 164603 [details]
Patch

Ok.
Comment 7 WebKit Review Bot 2012-09-18 14:38:33 PDT 
Comment on attachment 164603 [details]
Patch

Clearing flags on attachment: 164603

Committed r128933: <http://trac.webkit.org/changeset/128933>
Comment 8 WebKit Review Bot 2012-09-18 14:38:37 PDT 
All reviewed patches have been landed.  Closing bug.