Bug 97028 - [BlackBerry] Popup page should reference the client with a weak pointer
Summary: [BlackBerry] Popup page should reference the client with a weak pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 10:58 PDT by Yong Li
Modified: 2012-09-18 12:26 PDT (History)
4 users (show)

See Also:


Attachments
the patch (6.34 KB, patch)
2012-09-18 11:39 PDT, Yong Li
rwlbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-09-18 10:58:27 PDT
so it won't crash when the client is destroyed earlier.
Comment 1 Yong Li 2012-09-18 11:39:50 PDT
Created attachment 164592 [details]
the patch
Comment 2 Rob Buis 2012-09-18 11:52:55 PDT
Comment on attachment 164592 [details]
the patch

Looks good.
Comment 3 Yong Li 2012-09-18 12:26:25 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/blackberry/ChangeLog
	M	Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp
	M	Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.h
Committed r128921