Bug 97023 - IndexedDB: Free up resources used by completed cursors earlier
Summary: IndexedDB: Free up resources used by completed cursors earlier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 09:27 PDT by Joshua Bell
Modified: 2012-09-19 13:35 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.25 KB, patch)
2012-09-18 10:12 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch (11.34 KB, patch)
2012-09-18 10:40 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-09-18 09:27:51 PDT
IndexedDB: Free up resources used by completed cursors earlier
Comment 1 Joshua Bell 2012-09-18 10:12:25 PDT
Created attachment 164581 [details]
Patch
Comment 2 Joshua Bell 2012-09-18 10:17:35 PDT
I'd swear we used to do this (free up cursor resources when the cursor hits the end) but I'm not finding the code. Perhaps it's in the chromium prefetch paths?

Regardless - not a huge win, but for a long-lived transaction this would prevent cursors from piling up if they have been "completed", although it's unclear that pattern will be common.
Comment 3 Joshua Bell 2012-09-18 10:17:53 PDT
alec, david - take a look, but not urgent
Comment 4 Joshua Bell 2012-09-18 10:40:54 PDT
Created attachment 164584 [details]
Patch
Comment 5 Alec Flett 2012-09-18 11:41:58 PDT
Comment on attachment 164584 [details]
Patch

LGTM
Comment 6 Joshua Bell 2012-09-18 12:05:08 PDT
tony@ - another one, not urgent - r?
Comment 7 WebKit Review Bot 2012-09-19 13:34:57 PDT
Comment on attachment 164584 [details]
Patch

Clearing flags on attachment: 164584

Committed r129038: <http://trac.webkit.org/changeset/129038>
Comment 8 WebKit Review Bot 2012-09-19 13:35:00 PDT
All reviewed patches have been landed.  Closing bug.