RESOLVED FIXED 97022
Revert 128780, 128676, 128645 
https://bugs.webkit.org/show_bug.cgi?id=97022
Summary Revert 128780, 128676, 128645
Bo Liu
Reported 2012-09-18 09:08:56 PDT
Revert 128780, 128676, 128645
Attachments
Patch (37.75 KB, patch)
2012-09-18 09:09 PDT, Bo Liu 		no flags
DetailsFormatted DiffDiff
Improve ChangeLog description (38.54 KB, patch)
2012-09-18 09:21 PDT, Bo Liu 		no flags
DetailsFormatted DiffDiff
Fix mistake in InternalSettings with INPUT_TYPE_TIME_MULTIPLE_FIELDS (38.16 KB, patch)
2012-09-18 09:34 PDT, Bo Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bo Liu
Comment 1 2012-09-18 09:09:57 PDT
Created attachment 164571 [details] Patch
Darin Adler
Comment 2 2012-09-18 09:13:46 PDT
Unclear change set. Really need more context here. What are those revisions? Who submitted them? What were they trying to accomplish? Have you contacted the original author?
Bo Liu
Comment 3 2012-09-18 09:15:09 PDT
(In reply to comment #2) > Unclear change set. Really need more context here. What are those revisions? Who submitted them? What were they trying to accomplish? Have you contacted the original author? I am the author of all 3 patches. Reverting because they cause performance regression in chromium. See crbug.com/150021
Darin Adler
Comment 4 2012-09-18 09:16:12 PDT
(In reply to comment #3) > (In reply to comment #2) > > Unclear change set. Really need more context here. What are those revisions? Who submitted them? What were they trying to accomplish? Have you contacted the original author? > > I am the author of all 3 patches. Reverting because they cause performance regression in chromium. See crbug.com/150021 Got it. Could you please add some of that context to the change log? Please don’t assume people know you wrote the code. Or assume they will read the Chromium bug database to understand WebKit code changes.
Bo Liu
Comment 5 2012-09-18 09:21:23 PDT
Created attachment 164576 [details] Improve ChangeLog description
WebKit Review Bot
Comment 6 2012-09-18 09:24:41 PDT
Attachment 164576 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 LayoutTests/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] ChangeLog:10: Line contains tab character. [whitespace/tab] [5] ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 8 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Bo Liu
Comment 7 2012-09-18 09:34:31 PDT
Created attachment 164578 [details] Fix mistake in InternalSettings with INPUT_TYPE_TIME_MULTIPLE_FIELDS
WebKit Review Bot
Comment 8 2012-09-18 11:17:48 PDT
Comment on attachment 164578 [details] Fix mistake in InternalSettings with INPUT_TYPE_TIME_MULTIPLE_FIELDS Clearing flags on attachment: 164578 Committed r128914: <http://trac.webkit.org/changeset/128914>
WebKit Review Bot
Comment 9 2012-09-18 11:17:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.