Bug 97016 - Web Inspector: setPropertyValue does not work for non-finite numbers
Summary: Web Inspector: setPropertyValue does not work for non-finite numbers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 07:05 PDT by Andrey Adaikin
Modified: 2012-09-20 05:44 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.37 KB, patch)
2012-09-18 07:08 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-09-18 07:05:09 PDT 
Patch to follow.
Comment 1 Andrey Adaikin 2012-09-18 07:08:22 PDT 
Created attachment 164552 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-09-18 09:05:02 PDT 
Comment on attachment 164552 [details]
Patch

This looks like a hack. I think this should be fixed on a lower (protocol) level as a workaround for JSON.stringify/JSON.parse not supporting infinite values.
Comment 3 Andrey Adaikin 2012-09-19 07:56:39 PDT 
Otherwise we should hack the public remote debugging protocol API.
As discussed with Pavel, we decided to live with this workaround for now.
Comment 4 WebKit Review Bot 2012-09-20 05:44:29 PDT 
Comment on attachment 164552 [details]
Patch

Clearing flags on attachment: 164552

Committed r129122: <http://trac.webkit.org/changeset/129122>
Comment 5 WebKit Review Bot 2012-09-20 05:44:32 PDT 
All reviewed patches have been landed.  Closing bug.