Bug 97015 - [EFL][WK2] Implement PageClientImpl::isViewFocused.
Summary: [EFL][WK2] Implement PageClientImpl::isViewFocused.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 06:44 PDT by Ryuan Choi
Modified: 2012-09-18 18:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2012-09-18 07:00 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2012-09-18 17:36 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-09-18 06:44:47 PDT 
In WebKit2/Efl, PageClientImpl::isViewFocused always return true.
So contents can not receive window.onblur although webview lost focus.
Comment 1 Ryuan Choi 2012-09-18 07:00:05 PDT 
Created attachment 164550 [details]
Patch
Comment 2 Chris Dumez 2012-09-18 07:05:18 PDT 
Comment on attachment 164550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164550&action=review

Can you unskip any test with this fix?

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:45
> +    void setViewFocused(bool isFocused) { m_isViewFocused = isFocused; }

Why do we need this?

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:57
> +    virtual bool isViewFocused() { return m_isViewFocused; }

evas_object_focus_get(m_viewWidget) ?

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:122
> +    bool m_isViewFocused;

Why do we need a new member? We can certainly get focused state from m_viewWidget, right?
Comment 3 Ryuan Choi 2012-09-18 17:36:03 PDT 
Created attachment 164639 [details]
Patch
Comment 4 Ryuan Choi 2012-09-18 17:38:02 PDT 
(In reply to comment #2)
> (From update of attachment 164550 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164550&action=review
> 
> Can you unskip any test with this fix?

My results are same with this.

> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:45
> > +    void setViewFocused(bool isFocused) { m_isViewFocused = isFocused; }
> 
> Why do we need this?
> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:57
> > +    virtual bool isViewFocused() { return m_isViewFocused; }
> 
> evas_object_focus_get(m_viewWidget) ?
> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:122
> > +    bool m_isViewFocused;
> 
> Why do we need a new member? We can certainly get focused state from m_viewWidget, right?

yes, it is enough.
Fixed.
Comment 5 Gyuyoung Kim 2012-09-18 18:23:02 PDT 
Comment on attachment 164639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164639&action=review

> Source/WebKit2/ChangeLog:9
> +        So window.onblur events will not be generated when webview lost focus.

lost -> losts ?
Comment 6 Gyuyoung Kim 2012-09-18 18:25:31 PDT 
Comment on attachment 164639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164639&action=review

>> Source/WebKit2/ChangeLog:9
>> +        So window.onblur events will not be generated when webview lost focus.
> 
> lost -> losts ?

No ?
Comment 7 WebKit Review Bot 2012-09-18 18:32:41 PDT 
Comment on attachment 164639 [details]
Patch

Clearing flags on attachment: 164639

Committed r128958: <http://trac.webkit.org/changeset/128958>
Comment 8 WebKit Review Bot 2012-09-18 18:32:45 PDT 
All reviewed patches have been landed.  Closing bug.