Bug 97014 - [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
Summary: [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 06:38 PDT by Mikhail Pozdnyakov
Modified: 2012-09-18 08:00 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.96 KB, patch)
2012-09-18 06:41 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-09-18 06:38:33 PDT 
According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall be used for literals rather than WTF::StringBuilder::append().
Comment 1 Mikhail Pozdnyakov 2012-09-18 06:41:08 PDT 
Created attachment 164547 [details]
patch
Comment 2 Chris Dumez 2012-09-18 06:41:49 PDT 
Comment on attachment 164547 [details]
patch

LGTM.
Comment 3 WebKit Review Bot 2012-09-18 08:00:22 PDT 
Comment on attachment 164547 [details]
patch

Clearing flags on attachment: 164547

Committed r128895: <http://trac.webkit.org/changeset/128895>
Comment 4 WebKit Review Bot 2012-09-18 08:00:26 PDT 
All reviewed patches have been landed.  Closing bug.