Bug 97012 - Web Inspector: [Extensions API] postpone requests to add extensions until extension server is initialized
Summary: Web Inspector: [Extensions API] postpone requests to add extensions until ext...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-18 06:25 PDT by Andrey Kosyakov
Modified: 2012-09-18 07:14 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2012-09-18 06:28 PDT, Andrey Kosyakov 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-09-18 06:25:07 PDT 
Currently, requests to add extensions may arrive before we actually request extensions list in ExtensionServer.initExtensions(). One reason for that is chromium (InspectorExtensionsRegistry.getExtensionsAsync() is a no-op, we always send the extension list from the browser), another potential code path is remote front-end extensions using window.addExtension(). This may lead to extensions sending requests before extension subsystem is initialized (i.e. we install event listeners etc).

Thanks to johnjbarton@chromium.org for investigating this.
Comment 1 Andrey Kosyakov 2012-09-18 06:28:36 PDT 
Created attachment 164544 [details]
Patch
Comment 2 Andrey Kosyakov 2012-09-18 07:14:01 PDT 
Committed r128892: <http://trac.webkit.org/changeset/128892>