Bug 97011 - Implement 'mask-type' for <mask>
: Implement 'mask-type' for <mask>
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: SVG
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Dirk Schulze
http://dvcs.w3.org/hg/FXTF/raw-file/t...
:
Depends on:
Blocks: 95389
  Show dependency treegraph
 
Reported: 2012-09-18 06:24 PDT by Dirk Schulze
Modified: 2012-09-19 10:50 PDT (History)
10 users (show)

See Also:


Attachments
Patch (21.56 KB, patch)
2012-09-18 06:51 PDT, Dirk Schulze
akling: review+
akling: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2012-09-18 06:24:56 PDT
Implement 'mask-type' for <mask> from the CSS Masking specification. It allows switching the mask to use alpha masking.
Comment 1 Dirk Schulze 2012-09-18 06:51:24 PDT
Created attachment 164549 [details]
Patch
Comment 2 Andreas Kling 2012-09-19 08:12:35 PDT
Comment on attachment 164549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164549&action=review

Looks good!
r=me with the below mistake fixed. (Perhaps we could even add a test for it?)

> Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:197
>          case CSSPropertyMarker:
> +        case CSSPropertyMaskType:
> +            return CSSPrimitiveValue::create(svgStyle->maskType());

Beep beep! Mistake here: We shouldn't return the mask type for CSSPropertyMarker.
Comment 3 Dirk Schulze 2012-09-19 10:50:24 PDT
Committed r129018: <http://trac.webkit.org/changeset/129018>