Bug 96999 – Web Inspector: [Styles] For group selectors, transmit their segments with the "matches" flag

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Bug 96626 implemented the highlighting of matched individual selectors in grouped selectors. This can be done more effectively by modifying the protocol to transmit the grouped selectors broken down by comma-separated individual selectors, each having a flag telling whether the related node matches the selector.

[Alexander Pavlov (apavlov)]

Created attachment 164716 [details]
Patch

[Alexander Pavlov (apavlov)]

Created attachment 164870 [details]
Patch

[Pavel Feldman]

Comment on attachment 164870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164870&action=review

> Source/WebCore/ChangeLog:11
> +        * inspector/Inspector.json: Introduce SelectorSegment type and add elementMatchData field to CSSRule.

Lets add a test!

> Source/WebCore/inspector/Inspector.json:2027
> +                "id": "SelectorSegment",

SelectorList and Selector ?

> Source/WebCore/inspector/Inspector.json:2031
> +                    { "name": "matched", "type": "boolean", "optional": true, "description": "Whether the related element matches this selector segment (default: false)." }

matching ?

> Source/WebCore/inspector/Inspector.json:2073
> +                    { "name": "elementMatchData", "type": "array", "items": { "$ref": "SelectorSegment" }, "optional": true, "description": "Present for style rules' grouping selectors if a context element is known and not all individual selectors are matched. Contains element matching data for each selector segment."},

I would introduce the SelectorList class and refer to it from here (it would encapsulate selectorText and selectorRange)

> Source/WebCore/inspector/InspectorCSSAgent.cpp:684
> +    if (selectorList.hasOneSelector())

Lets provide this information at all times as a start - it would make front-end life easier.

[Alexander Pavlov (apavlov)]

Created attachment 165334 [details]
Patch

[Pavel Feldman]

Comment on attachment 165334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165334&action=review

> Source/WebCore/inspector/Inspector.json:2013
> +                    { "name": "matches", "type": "array", "items": { "$ref": "RuleMatch" }, "description": "Matches of CSS rules applicable to the pseudo style."}

Rename the group to PseudoIdMatches ?

> Source/WebCore/inspector/Inspector.json:2031
> +                    { "name": "matchingIndices", "type": "array", "items": { "type": "integer" }, "description": "Matching selector indices in the rule's selectorList selectors (0-based)." }

matchingSelectors

[Alexander Pavlov (apavlov)]

Committed r129470: <http://trac.webkit.org/changeset/129470>