Bug 96975 - [Gtk] Remove the unused variable warning in GamepadsGtk.cpp using ASSERT_UNUSED macro
Summary: [Gtk] Remove the unused variable warning in GamepadsGtk.cpp using ASSERT_UNUS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 20:56 PDT by Vivek Galatage
Modified: 2012-09-17 21:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2012-09-17 21:06 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2012-09-17 20:56:01 PDT 
The following warning is thrown:

../../Source/WebCore/platform/gtk/GamepadsGtk.cpp: In static member function ‘static gboolean WebCore::GamepadDeviceGtk::readCallback(GObject*, gpointer)’:
../../Source/WebCore/platform/gtk/GamepadsGtk.cpp:85:12: warning: unused variable ‘len’ [-Wunused-variable]

This warning can be avoided using the ASSERT_UNUSED macro.

Patch to follow.
Comment 1 Vivek Galatage 2012-09-17 21:06:36 PDT 
Created attachment 164487 [details]
Patch
Comment 2 Kentaro Hara 2012-09-17 21:17:56 PDT 
Comment on attachment 164487 [details]
Patch

rs=me
Comment 3 Vivek Galatage 2012-09-17 21:23:39 PDT 
(In reply to comment #2)
> (From update of attachment 164487 [details])
> rs=me

Thank you!
Comment 4 WebKit Review Bot 2012-09-17 21:37:28 PDT 
Comment on attachment 164487 [details]
Patch

Clearing flags on attachment: 164487

Committed r128848: <http://trac.webkit.org/changeset/128848>
Comment 5 WebKit Review Bot 2012-09-17 21:37:31 PDT 
All reviewed patches have been landed.  Closing bug.