Bug 96973 - DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
Summary: DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 20:19 PDT by Pratik Solanki
Modified: 2012-09-17 23:34 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2012-09-17 20:25 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2012-09-17 22:22 PDT, Pratik Solanki 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2012-09-17 20:19:27 PDT 
We should pass -Wundef to DRT builds.
Comment 1 Pratik Solanki 2012-09-17 20:25:42 PDT 
Created attachment 164486 [details]
Patch
Comment 2 mitz 2012-09-17 20:27:10 PDT 
Comment on attachment 164486 [details]
Patch

What about WebKitTestRunner?
Comment 3 Pratik Solanki 2012-09-17 22:12:41 PDT 
(In reply to comment #2)
> (From update of attachment 164486 [details])
> What about WebKitTestRunner?

Yeah we should add -Wundef there as well. I'll post an updated patch.
Comment 4 Pratik Solanki 2012-09-17 22:22:39 PDT 
Created attachment 164494 [details]
Patch
Comment 5 Pratik Solanki 2012-09-17 23:34:57 PDT 
Committed r128852: <http://trac.webkit.org/changeset/128852>