WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 96963
Roll chromium DEPS to
r157342
https://bugs.webkit.org/show_bug.cgi?id=96963
Summary
Roll chromium DEPS to r157342
Terry Anderson
Reported
2012-09-17 15:36:12 PDT
Roll chromium DEPS to
r157188
Attachments
Patch
(1.09 KB, patch)
2012-09-17 15:37 PDT
,
Terry Anderson
no flags
Details
Formatted Diff
Diff
Patch
(1.09 KB, patch)
2012-09-18 07:18 PDT
,
Terry Anderson
no flags
Details
Formatted Diff
Diff
Patch
(1.49 KB, patch)
2012-09-18 07:47 PDT
,
Terry Anderson
no flags
Details
Formatted Diff
Diff
Patch
(1.37 KB, patch)
2012-09-18 07:55 PDT
,
Terry Anderson
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.33 KB, patch)
2012-09-18 07:59 PDT
,
Terry Anderson
senorblanco
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Terry Anderson
Comment 1
2012-09-17 15:37:39 PDT
Created
attachment 164463
[details]
Patch
WebKit Review Bot
Comment 2
2012-09-17 15:42:08 PDT
Comment on
attachment 164463
[details]
Patch
Attachment 164463
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/13892004
Stephen White
Comment 3
2012-09-17 15:43:01 PDT
Doesn't look like this rev wants to build. :(
Peter Beverloo (cr-android ews)
Comment 4
2012-09-17 15:55:00 PDT
Comment on
attachment 164463
[details]
Patch
Attachment 164463
[details]
did not pass cr-android-ews (chromium-android): Output:
http://queues.webkit.org/results/13870573
Terry Anderson
Comment 5
2012-09-18 07:18:16 PDT
Created
attachment 164555
[details]
Patch
WebKit Review Bot
Comment 6
2012-09-18 07:23:16 PDT
Comment on
attachment 164555
[details]
Patch
Attachment 164555
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/13896204
Peter Beverloo (cr-android ews)
Comment 7
2012-09-18 07:38:54 PDT
Comment on
attachment 164555
[details]
Patch
Attachment 164555
[details]
did not pass cr-android-ews (chromium-android): Output:
http://queues.webkit.org/results/13904168
Terry Anderson
Comment 8
2012-09-18 07:47:42 PDT
Created
attachment 164559
[details]
Patch
WebKit Review Bot
Comment 9
2012-09-18 07:53:02 PDT
Comment on
attachment 164559
[details]
Patch
Attachment 164559
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/13898196
Terry Anderson
Comment 10
2012-09-18 07:55:40 PDT
Created
attachment 164561
[details]
Patch
Terry Anderson
Comment 11
2012-09-18 07:59:46 PDT
Created
attachment 164562
[details]
Patch for landing
WebKit Review Bot
Comment 12
2012-09-18 08:20:06 PDT
Comment on
attachment 164562
[details]
Patch for landing Rejecting
attachment 164562
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/13894219
Stephen White
Comment 13
2012-09-18 09:04:29 PDT
Comment on
attachment 164562
[details]
Patch for landing OK. r=me
WebKit Review Bot
Comment 14
2012-09-18 09:06:45 PDT
Comment on
attachment 164562
[details]
Patch for landing Rejecting
attachment 164562
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://queues.webkit.org/results/13900232
Stephen White
Comment 15
2012-09-18 09:09:38 PDT
Don't remove the "OOPS" line from the ChangeLog; the commit script will substitute the correct reviewer's name on landing.
Peter Beverloo
Comment 16
2012-09-18 09:20:49 PDT
Committed
r128901
: <
http://trac.webkit.org/changeset/128901
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug