Bug 96963 - Roll chromium DEPS to r157342
Summary: Roll chromium DEPS to r157342
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Terry Anderson
URL:
Keywords:
Depends on:
Blocks: 96137
  Show dependency tree / graph
 
Reported: 2012-09-17 15:36 PDT by Terry Anderson
Modified: 2012-09-18 09:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.09 KB, patch)
2012-09-17 15:37 PDT, Terry Anderson 		no flags Details | Formatted Diff | Diff
Patch (1.09 KB, patch)
2012-09-18 07:18 PDT, Terry Anderson 		no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2012-09-18 07:47 PDT, Terry Anderson 		no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2012-09-18 07:55 PDT, Terry Anderson 		no flags Details | Formatted Diff | Diff
Patch for landing (1.33 KB, patch)
2012-09-18 07:59 PDT, Terry Anderson 		senorblanco: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Anderson 2012-09-17 15:36:12 PDT 
Roll chromium DEPS to r157188
Comment 1 Terry Anderson 2012-09-17 15:37:39 PDT 
Created attachment 164463 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-17 15:42:08 PDT 
Comment on attachment 164463 [details]
Patch

Attachment 164463 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13892004
Comment 3 Stephen White 2012-09-17 15:43:01 PDT 
Doesn't look like this rev wants to build.  :(
Comment 4 Peter Beverloo (cr-android ews) 2012-09-17 15:55:00 PDT 
Comment on attachment 164463 [details]
Patch

Attachment 164463 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13870573
Comment 5 Terry Anderson 2012-09-18 07:18:16 PDT 
Created attachment 164555 [details]
Patch
Comment 6 WebKit Review Bot 2012-09-18 07:23:16 PDT 
Comment on attachment 164555 [details]
Patch

Attachment 164555 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13896204
Comment 7 Peter Beverloo (cr-android ews) 2012-09-18 07:38:54 PDT 
Comment on attachment 164555 [details]
Patch

Attachment 164555 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13904168
Comment 8 Terry Anderson 2012-09-18 07:47:42 PDT 
Created attachment 164559 [details]
Patch
Comment 9 WebKit Review Bot 2012-09-18 07:53:02 PDT 
Comment on attachment 164559 [details]
Patch

Attachment 164559 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13898196
Comment 10 Terry Anderson 2012-09-18 07:55:40 PDT 
Created attachment 164561 [details]
Patch
Comment 11 Terry Anderson 2012-09-18 07:59:46 PDT 
Created attachment 164562 [details]
Patch for landing
Comment 12 WebKit Review Bot 2012-09-18 08:20:06 PDT 
Comment on attachment 164562 [details]
Patch for landing

Rejecting attachment 164562 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13894219
Comment 13 Stephen White 2012-09-18 09:04:29 PDT 
Comment on attachment 164562 [details]
Patch for landing

OK.  r=me
Comment 14 WebKit Review Bot 2012-09-18 09:06:45 PDT 
Comment on attachment 164562 [details]
Patch for landing

Rejecting attachment 164562 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13900232
Comment 15 Stephen White 2012-09-18 09:09:38 PDT 
Don't remove the "OOPS" line from the ChangeLog; the commit script will substitute the correct reviewer's name on landing.
Comment 16 Peter Beverloo 2012-09-18 09:20:49 PDT 
Committed r128901: <http://trac.webkit.org/changeset/128901>