Bug 96955 - Refactored the arguments object so it doesn't dictate closure layout
Summary: Refactored the arguments object so it doesn't dictate closure layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 14:46 PDT by Geoffrey Garen
Modified: 2012-09-17 18:14 PDT (History)
0 users

See Also:

Attachments
Patch (51.91 KB, patch)
2012-09-17 15:09 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-09-17 14:46:21 PDT 
Refactored the arguments object so it doesn't dictate closure layout
Comment 1 Geoffrey Garen 2012-09-17 15:09:57 PDT 
Created attachment 164459 [details]
Patch
Comment 2 Geoffrey Garen 2012-09-17 15:12:33 PDT 
Oliver asked if it's common for websites to capture arguments by name and use the arguments object at the same time. There seems to one idiom where it is common: by-hand implementation of function.bind. 

I don't believe I've made this case worse than it is today, since this case reifies the arguments object to pass it to slice, etc., which disables our optimizations. Also, I don't believe this patch is incompatible with optimization, if we first eliminated the reification.
Comment 3 Geoffrey Garen 2012-09-17 18:14:31 PDT 
Committed r128832: <http://trac.webkit.org/changeset/128832>