Bug 96954 - [BlackBerry] Remove dysfunctional zoom blit in setViewportSize()
Summary: [BlackBerry] Remove dysfunctional zoom blit in setViewportSize()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
Depends on:
Reported: 2012-09-17 14:39 PDT by Jakob Petsovits
Modified: 2012-09-17 15:50 PDT (History)
4 users (show)

See Also:

Patch (4.91 KB, patch)
2012-09-17 14:44 PDT, Jakob Petsovits
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2012-09-17 14:39:58 PDT
The blitContents() call removed by this patch used to be part of scheduleZoomAboutPoint(). Its goal was to display a preview of the zoomed contents, primarily when auto-zoomed after rotation. Nested inside a pair of screen suspend/resume calls, it has been a pointless no-op for a while.

Antonio's recent change to remove scheduleZoomAboutPoint() and call zoomAboutPoint() from setViewportSize() directly (the only call site) obsoletes the call completely. The zoomAboutPoint() call itself will cause a re-render and blit right away, so we don't care about any preview. zoomAboutPoint() will also take care of the necessary screen/backingstore suspension.

The result is a vastly simplified block of code.

Further simplification seems feasible, but is not exactly logically equivalent so I have to check with other people on how exactly they are meant to function. In order to minimize the risk of unintended regressions, this patch leaves out those sensitive pieces.
Comment 1 Jakob Petsovits 2012-09-17 14:44:40 PDT
Created attachment 164454 [details]
Comment 2 WebKit Review Bot 2012-09-17 15:50:40 PDT
Comment on attachment 164454 [details]

Clearing flags on attachment: 164454

Committed r128817: <http://trac.webkit.org/changeset/128817>
Comment 3 WebKit Review Bot 2012-09-17 15:50:43 PDT
All reviewed patches have been landed.  Closing bug.