Bug 96945 - REGRESSION (r128678): Several tests fail on WK2 bots (compositing/rtl/rtl-fixed-overflow.html, compositing/rtl/rtl-fixed.html, fast/regions/float-pushed-width-change.html, fast/repaint/fixed-move-after-keyboard-scroll.html)
Summary: REGRESSION (r128678): Several tests fail on WK2 bots (compositing/rtl/rtl-fix...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 12:44 PDT by Alexey Proskuryakov
Modified: 2012-09-17 15:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (33.49 KB, patch)
2012-09-17 14:32 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-09-17 12:44:06 PDT 
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r128782%20(1139)/results.html

There is one more layer than before:

--- /Volumes/Data/slave/mountainlion-debug-tests-wk2/build/layout-test-results/compositing/rtl/rtl-fixed-overflow-expected.txt
+++ /Volumes/Data/slave/mountainlion-debug-tests-wk2/build/layout-test-results/compositing/rtl/rtl-fixed-overflow-actual.txt
@@ -4,7 +4,12 @@
   (children 1
     (GraphicsLayer
       (bounds 1000.00 1000.00)
-      (children 1
+      (children 2
+        (GraphicsLayer
+          (position 265.00 50.00)
+          (bounds 100.00 100.00)
+          (drawsContent 1)
+        )
         (GraphicsLayer
           (position 265.00 50.00)
           (bounds 100.00 100.00)
Comment 1 Alexey Proskuryakov 2012-09-17 12:55:47 PDT 
Confusingly, r128678 added expected results for platform/mac, but those are the same as cross platform ones.
Comment 2 Alexey Proskuryakov 2012-09-17 12:59:05 PDT 
Two more tests affected by r128678 on WebKit2 only:
fast/repaint/fixed-move-after-keyboard-scroll.html
fast/regions/float-pushed-width-change.html
Comment 3 Simon Fraser (smfr) 2012-09-17 13:54:05 PDT 
Probably because of Beth's fixed position stuff?
Comment 4 Beth Dakin 2012-09-17 13:55:27 PDT 
(In reply to comment #3)
> Probably because of Beth's fixed position stuff?

Yes, I'm working on it. We need some wk2-specific test results because of the fact that we're only doing setAcceleratedCompositingForFixedPositionEnabled(true) in WK2, not WK1.
Comment 5 Beth Dakin 2012-09-17 14:32:23 PDT 
Created attachment 164453 [details]
Patch
Comment 6 Tim Horton 2012-09-17 14:46:11 PDT 
Comment on attachment 164453 [details]
Patch

r=me, assuming you've checked with the person who wrote the test that you're changing (fast/regions/float-pushed-width-change). Does seem safe, though.
Comment 7 Beth Dakin 2012-09-17 15:16:50 PDT 
Thanks, Tim! http://trac.webkit.org/changeset/128811