Bug 96943 - Measure the usage of window.webkitIndexedDB so we can measure the transition to webkit.indexedDB
Summary: Measure the usage of window.webkitIndexedDB so we can measure the transition ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 12:35 PDT by Adam Barth
Modified: 2012-09-17 13:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2012-09-17 12:36 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-17 12:35:19 PDT 
Measure the usage of window.webkitIndexedDB so we can measure the transition to webkit.indexedDB
Comment 1 Adam Barth 2012-09-17 12:36:16 PDT 
Created attachment 164441 [details]
Patch
Comment 2 Ojan Vafai 2012-09-17 12:49:32 PDT 
Comment on attachment 164441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164441&action=review

> Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl:33
> +        readonly attribute [V8MeasureAs=PrefixedIndexedDB] IDBFactory webkitIndexedDB;

bikeshed: Why not WebKitIndexedDB?
Comment 3 Adam Barth 2012-09-17 12:54:01 PDT 
(In reply to comment #2)
> (From update of attachment 164441 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164441&action=review
> 
> > Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl:33
> > +        readonly attribute [V8MeasureAs=PrefixedIndexedDB] IDBFactory webkitIndexedDB;
> 
> bikeshed: Why not WebKitIndexedDB?

I was planning to call unprefixed one UnprefixedIndexedDB.  Calling the unprefixed one just "IndexedDB" isn't as clear because you don't know if its all uses of IndexedDB.
Comment 4 Adam Barth 2012-09-17 13:37:12 PDT 
Comment on attachment 164441 [details]
Patch

Clearing flags on attachment: 164441

Committed r128798: <http://trac.webkit.org/changeset/128798>
Comment 5 Adam Barth 2012-09-17 13:37:13 PDT 
All reviewed patches have been landed.  Closing bug.