Bug 96925 - [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
Summary: [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Abbas Sherawala
URL:
Keywords:
Depends on: 96696
Blocks: 96927
  Show dependency tree / graph
 
Reported: 2012-09-17 08:20 PDT by Antonio Gomes
Modified: 2012-09-19 08:15 PDT (History)
4 users (show)

See Also:

Attachments
patch (3.49 KB, patch)
2012-09-17 08:25 PDT, Antonio Gomes 		no flags Details | Formatted Diff | Diff
patch (3.30 KB, patch)
2012-09-17 08:41 PDT, Antonio Gomes 		rwlbuis: review+
Details | Formatted Diff | Diff
Added missing if (2.16 KB, patch)
2012-09-19 07:27 PDT, Abbas Sherawala 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-09-17 08:20:32 PDT 
... by committing the root layer (if needed) right way. Remember, it calls blitVisibleContents, so what we are actually doing is shortcutting when AC content will get on screen.
Comment 1 Antonio Gomes 2012-09-17 08:25:13 PDT 
Created attachment 164399 [details]
patch
Comment 2 WebKit Review Bot 2012-09-17 08:26:43 PDT 
Attachment 164399 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BackingStore...." exit_code: 1
Source/WebKit/blackberry/Api/BackingStore.cpp:363:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/Api/BackingStore.cpp:366:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/Api/BackingStore.cpp:370:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antonio Gomes 2012-09-17 08:41:16 PDT 
Created attachment 164401 [details]
patch

Style issues fixed.
Comment 4 Rob Buis 2012-09-17 08:44:32 PDT 
Comment on attachment 164401 [details]
patch

LGTM.
Comment 5 Antonio Gomes 2012-09-17 09:08:54 PDT 
http://trac.webkit.org/changeset/128766
Comment 6 Antonio Gomes 2012-09-19 06:53:44 PDT 
missing IF
Comment 7 Abbas Sherawala 2012-09-19 07:27:52 PDT 
Created attachment 164735 [details]
Added missing if

Added the missing if
Comment 8 WebKit Review Bot 2012-09-19 07:51:45 PDT 
Comment on attachment 164735 [details]
Added missing if

Clearing flags on attachment: 164735

Committed r129006: <http://trac.webkit.org/changeset/129006>