Bug 96920 – [EFL] min-device-width failures in media tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

The following test cases fail on the bots:
 fast/media/invalid-lengths.html
 fast/media/matchmedium-query-api.html
 fast/media/media-query-list-01.html

The diffs look like:
-PASS: "(min-device-width: 1px)" evaluates to true.
+FAIL: "(min-device-width: 1px)" evaluates to false.

-"(min-device-width: 100px)" evaluates to true: PASS
+"(min-device-width: 100px)" evaluates to false: FAIL

-"(min-device-width: 100px)" evaluates to true: PASS
+"(min-device-width: 100px)" evaluates to false: FAIL

[Chris Dumez]

They fail on the bot because it does not run X. screenRect() in platform/efl returns O width and height in that case.

[Chris Dumez]

media/video-source-media.html fails for the same reason

[Chris Dumez]

*** Bug 96922 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Created attachment 164431 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 164431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164431&action=review

> Source/WebCore/platform/efl/PlatformScreenEfl.cpp:117
> +    int width = 800, height = 600;

I think a comment is valid here. also it should be two lines

[Chris Dumez]

Created attachment 164534 [details]
Patch for landing

Take Kenneth's feedback into consideration.

Could someone please cq+?

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 164431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164431&action=review

>> Source/WebCore/platform/efl/PlatformScreenEfl.cpp:117
>> +    int width = 800, height = 600;
> 
> I think a comment is valid here. also it should be two lines

Does it work only because the dimensions match the ones used in DRT/WTR?

[Chris Dumez]

(In reply to comment #7)
> (From update of attachment 164431 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164431&action=review
> 
> >> Source/WebCore/platform/efl/PlatformScreenEfl.cpp:117
> >> +    int width = 800, height = 600;
> > 
> > I think a comment is valid here. also it should be two lines
> 
> Does it work only because the dimensions match the ones used in DRT/WTR?

No, any realistic screen size would make those tests pass. Currently we return 0x0 which of course is unrealistic. Tests usually checks something like "width > 100px".

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 164534 [details]
Patch for landing

Right.

[WebKit Review Bot]

Comment on attachment 164534 [details]
Patch for landing

Clearing flags on attachment: 164534

Committed r128880: <http://trac.webkit.org/changeset/128880>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Raphael Kubo da Costa (:rakuco)]

For the record, the fast/dom/Window tests still fail here and on the bots, so I have skipped them again in <http://trac.webkit.org/changeset/128893>.