The following test cases fail on the bots: fast/media/invalid-lengths.html fast/media/matchmedium-query-api.html fast/media/media-query-list-01.html The diffs look like: -PASS: "(min-device-width: 1px)" evaluates to true. +FAIL: "(min-device-width: 1px)" evaluates to false. -"(min-device-width: 100px)" evaluates to true: PASS +"(min-device-width: 100px)" evaluates to false: FAIL -"(min-device-width: 100px)" evaluates to true: PASS +"(min-device-width: 100px)" evaluates to false: FAIL
They fail on the bot because it does not run X. screenRect() in platform/efl returns O width and height in that case.
media/video-source-media.html fails for the same reason
*** Bug 96922 has been marked as a duplicate of this bug. ***
Created attachment 164431 [details] Patch
Comment on attachment 164431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164431&action=review > Source/WebCore/platform/efl/PlatformScreenEfl.cpp:117 > + int width = 800, height = 600; I think a comment is valid here. also it should be two lines
Created attachment 164534 [details] Patch for landing Take Kenneth's feedback into consideration. Could someone please cq+?
Comment on attachment 164431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164431&action=review >> Source/WebCore/platform/efl/PlatformScreenEfl.cpp:117 >> + int width = 800, height = 600; > > I think a comment is valid here. also it should be two lines Does it work only because the dimensions match the ones used in DRT/WTR?
(In reply to comment #7) > (From update of attachment 164431 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164431&action=review > > >> Source/WebCore/platform/efl/PlatformScreenEfl.cpp:117 > >> + int width = 800, height = 600; > > > > I think a comment is valid here. also it should be two lines > > Does it work only because the dimensions match the ones used in DRT/WTR? No, any realistic screen size would make those tests pass. Currently we return 0x0 which of course is unrealistic. Tests usually checks something like "width > 100px".
Comment on attachment 164534 [details] Patch for landing Right.
Comment on attachment 164534 [details] Patch for landing Clearing flags on attachment: 164534 Committed r128880: <http://trac.webkit.org/changeset/128880>
All reviewed patches have been landed. Closing bug.
For the record, the fast/dom/Window tests still fail here and on the bots, so I have skipped them again in <http://trac.webkit.org/changeset/128893>.