Bug 96917 - Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent
Summary: Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on: 97083
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-17 06:59 PDT by Andrey Adaikin
Modified: 2012-09-19 06:07 PDT (History)
18 users (show)

See Also:

Attachments
Patch (254.78 KB, patch)
2012-09-17 08:20 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (254.19 KB, patch)
2012-09-19 05:05 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-09-17 06:59:10 PDT 
Rename WebGLAgent* and WebGLInstrumentation* files to Canvas* as we will support both 2D and 3D/WebGL canvas instrumentation.
Comment 1 Andrey Adaikin 2012-09-17 08:20:55 PDT 
Created attachment 164397 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-17 08:24:04 PDT 
Attachment 164397 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1
Source/WebCore/inspector/InjectedScriptCanvasModule.h:59:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScriptCanvasModule.cpp:97:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andrey Adaikin 2012-09-17 08:30:16 PDT 
Review in Rietveld: https://codereview.appspot.com/6495141/
Comment 4 WebKit Review Bot 2012-09-19 01:08:03 PDT 
Comment on attachment 164397 [details]
Patch

Clearing flags on attachment: 164397

Committed r128976: <http://trac.webkit.org/changeset/128976>
Comment 5 WebKit Review Bot 2012-09-19 01:08:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-09-19 01:27:56 PDT 
Re-opened since this is blocked by 97083
Comment 7 Andrey Adaikin 2012-09-19 03:32:36 PDT 
Compilation breaks on the InspectorAllInOne.o file, although InspectorAllInOne.cpp was updated in the patch. Probably a clean rebuild is needed on the bot, rather than an incremental build?
Comment 8 Andrey Adaikin 2012-09-19 05:05:38 PDT 
Created attachment 164718 [details]
Patch
Comment 9 WebKit Review Bot 2012-09-19 05:09:57 PDT 
Attachment 164718 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1
Source/WebCore/inspector/InjectedScriptCanvasModule.h:59:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScriptCanvasModule.cpp:97:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Review Bot 2012-09-19 06:06:56 PDT 
Comment on attachment 164718 [details]
Patch

Clearing flags on attachment: 164718

Committed r128992: <http://trac.webkit.org/changeset/128992>
Comment 11 WebKit Review Bot 2012-09-19 06:07:01 PDT 
All reviewed patches have been landed.  Closing bug.