Bug 96913 - Web Inspector: NMI: now when we can detect instrumented classes we can remove addInstrumentedMember and use addMember for everything
Summary: Web Inspector: NMI: now when we can detect instrumented classes we can remove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 06:19 PDT by Ilya Tikhonovsky
Modified: 2012-09-17 08:12 PDT (History)
25 users (show)

See Also:

Attachments
Patch (100.56 KB, patch)
2012-09-17 06:24 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
comment addressed - visited check returned (100.96 KB, patch)
2012-09-17 06:47 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
rebaselined (101.89 KB, patch)
2012-09-17 06:58 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-09-17 06:19:59 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2012-09-17 06:24:25 PDT 
Created attachment 164381 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-17 06:37:24 PDT 
Comment on attachment 164381 [details]
Patch

Before switching to the new instrumentaion we should make sure it works, in particular the problem with MemoryInstrumentationTest failure should be addressed first: http://trac.webkit.org/changeset/128744
Comment 3 Ilya Tikhonovsky 2012-09-17 06:47:07 PDT 
Created attachment 164387 [details]
comment addressed - visited check returned
Comment 4 Ilya Tikhonovsky 2012-09-17 06:58:36 PDT 
Created attachment 164388 [details]
rebaselined
Comment 5 Ilya Tikhonovsky 2012-09-17 08:12:15 PDT 
Committed r128762: <http://trac.webkit.org/changeset/128762>