Bug 96911 - Web Inspector: NMI don't double count fields of StaticDOMDataStore
Summary: Web Inspector: NMI don't double count fields of StaticDOMDataStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 05:42 PDT by Yury Semikhatsky
Modified: 2012-09-17 06:32 PDT (History)
15 users (show)

See Also:

Attachments
Patch (6.33 KB, patch)
2012-09-17 05:45 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (5.41 KB, patch)
2012-09-17 06:20 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (5.51 KB, patch)
2012-09-17 06:28 PDT, Yury Semikhatsky 		apavlov: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-09-17 05:42:32 PDT 
DOMDataStore::reportMemoryUsage adds all referenced maps byPointers but in case of StaticDOMDataStore the maps are actually fields of StaticDOMDataStore and shouldn't be counted separately.
Comment 1 Yury Semikhatsky 2012-09-17 05:45:01 PDT 
Created attachment 164375 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-17 06:20:39 PDT 
Created attachment 164379 [details]
Patch
Comment 3 Ilya Tikhonovsky 2012-09-17 06:24:20 PDT 
Comment on attachment 164379 [details]
Patch

lgtm
Comment 4 Ilya Tikhonovsky 2012-09-17 06:25:42 PDT 
Comment on attachment 164379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164379&action=review

> Source/WebCore/bindings/v8/ScopedDOMDataStore.cpp:58
> +    info.addInstrumentedMember(m_domNodeMap);

please call base class instrumentation

> Source/WebCore/bindings/v8/StaticDOMDataStore.cpp:59
> +    MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::Binding);

please call base class instrumentation
Comment 5 Yury Semikhatsky 2012-09-17 06:28:35 PDT 
Created attachment 164383 [details]
Patch
Comment 6 Yury Semikhatsky 2012-09-17 06:28:58 PDT 
(In reply to comment #4)
> (From update of attachment 164379 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164379&action=review
> 
> > Source/WebCore/bindings/v8/ScopedDOMDataStore.cpp:58
> > +    info.addInstrumentedMember(m_domNodeMap);
> 
> please call base class instrumentation
> 
Done.

> > Source/WebCore/bindings/v8/StaticDOMDataStore.cpp:59
> > +    MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::Binding);
> 
> please call base class instrumentation
Done.
Comment 7 Alexander Pavlov (apavlov) 2012-09-17 06:30:52 PDT 
Comment on attachment 164379 [details]
Patch

rs=me
Comment 8 Yury Semikhatsky 2012-09-17 06:32:55 PDT 
Committed r128752: <http://trac.webkit.org/changeset/128752>