Bug 96908 - RenderLayer should not pretend to be hit when it is not
Summary: RenderLayer should not pretend to be hit when it is not
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks: 95204
  Show dependency treegraph
 
Reported: 2012-09-17 04:53 PDT by Allan Sandfeld Jensen
Modified: 2017-07-18 08:27 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.30 KB, patch)
2012-09-17 04:58 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-09-17 04:53:51 PDT
RenderLayer::hitTest currently has quirk where it pretends the layer was hit even if it was not, in case it is the top layer and the mouse-button is down, or just released.

This code is used to ensure the origin frame of a drag-operation accepts the event that is routed to it, and to ensure that hit-tests on a frame-view scroll bar (which are not hit-tested!) hits the document.

The first reason is unnecessary, since the EventHandler would already know that it is capturing drag events and not forwarding them to a deeper frame, and the second reason should be replaced with a more accurate test actually testing if the frameview scroll bar was hit (if participates in hit testing).
Comment 1 Allan Sandfeld Jensen 2012-09-17 04:58:12 PDT
Created attachment 164372 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-17 07:56:26 PDT
Comment on attachment 164372 [details]
Patch

Attachment 164372 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13864671

New failing tests:
touchadjustment/touch-links-longpress.html
WebFrameTest.SelectRange
fast/dom/shadow/selections-in-shadow.html
Comment 3 Allan Sandfeld Jensen 2012-09-17 09:36:20 PDT
Comment on attachment 164372 [details]
Patch

Clearing review. The patch was not fully handling selection by mouse-drag.