RESOLVED FIXED 96905
[EFL] Remove background view on EWebLauncher and MiniBrowser 
https://bugs.webkit.org/show_bug.cgi?id=96905
Summary [EFL] Remove background view on EWebLauncher and MiniBrowser
Seokju Kwon
Reported 2012-09-17 04:17:26 PDT
The background view doesn't display properly on test browsers after adding url bar. And Remove unnecessary codes.
Attachments
Patch (4.38 KB, patch)
2012-09-17 04:33 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Patch (4.42 KB, patch)
2012-09-18 03:23 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2012-09-17 04:33:34 PDT
Created attachment 164367 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-09-17 06:24:13 PDT
Comment on attachment 164367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164367&action=review > Tools/ChangeLog:9 > + The background view doesn't display properly on test browsers after adding url bar. > + And Remove unnecessary codes. The changes themselves look OK, but what kind of display failures were you experiencing? Plus, you only seem to be removing code related to the background view, not unnecessary one.
Seokju Kwon
Comment 3 2012-09-17 07:46:46 PDT
(In reply to comment #2) > (From update of attachment 164367 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164367&action=review > > > Tools/ChangeLog:9 > > + The background view doesn't display properly on test browsers after adding url bar. > > + And Remove unnecessary codes. > > The changes themselves look OK, but what kind of display failures were you experiencing? Plus, you only seem to be removing code related to the background view, not unnecessary one. I couldn't see the pink background any more after adding url bar. Plus Could you explain why it is necessary?
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-09-18 02:22:16 PDT
(In reply to comment #3) > I couldn't see the pink background any more after adding url bar. Makes sense, since r126419 changed the evas_object_{move,resize} calls. I would just say in the ChangeLog that having the background view is not necessary anymore, since it was used for debugging back in the day. > Plus Could you explain why it is necessary? ?
Seokju Kwon
Comment 5 2012-09-18 03:09:09 PDT
(In reply to comment #4) > (In reply to comment #3) > > I couldn't see the pink background any more after adding url bar. > > Makes sense, since r126419 changed the evas_object_{move,resize} calls. I would just say in the ChangeLog that having the background view is not necessary anymore, since it was used for debugging back in the day. > > > Plus Could you explain why it is necessary? > > ? I was just wondering whether background view is necessary or not now.
Seokju Kwon
Comment 6 2012-09-18 03:23:08 PDT
Created attachment 164523 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 7 2012-09-18 03:29:26 PDT
Comment on attachment 164523 [details] Patch Looks good, thanks.
WebKit Review Bot
Comment 8 2012-09-18 05:05:09 PDT
Comment on attachment 164523 [details] Patch Clearing flags on attachment: 164523 Committed r128876: <http://trac.webkit.org/changeset/128876>
WebKit Review Bot
Comment 9 2012-09-18 05:05:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.