Bug 96899 – [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Zan Dobersek]

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html is failing after introduced in r128645.
http://trac.webkit.org/changeset/128645

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-actual.txt 
@@ -1,3 +1,3 @@
 Test that DisplayImages disabled can block http image and can be reloaded in-place when toggled.
-SUCCESS
+FAILURE: Image should not be loaded when DisplayImage is unset
 

The test overrides WebKitDisplayImagesKey preference, but that's not yet supported.

[Zan Dobersek]

Created attachment 164428 [details]
Patch

[Martin Robinson]

Comment on attachment 164428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164428&action=review

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:707
> +void DumpRenderTreeSupportGtk::setLoadsImagesAutomatically(WebKitWebView* webView, bool enabled)
> +{
> +    core(webView)->settings()->setLoadsImagesAutomatically(enabled);
> +}

Why not just use the auto-load-images setting in WebKitWebSettings?

[Zan Dobersek]

Comment on attachment 164428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164428&action=review

>> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:707
>> +}
> 
> Why not just use the auto-load-images setting in WebKitWebSettings?

Ah, didn't see that when I was grepping. Of course, using that would be better.

[Zan Dobersek]

Created attachment 164449 [details]
Patch

[Martin Robinson]

Comment on attachment 164449 [details]
Patch

Thanks!

[Zan Dobersek]

Comment on attachment 164449 [details]
Patch

Clearing flags on attachment: 164449

Committed r128854: <http://trac.webkit.org/changeset/128854>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.