Bug 96899 - [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
Summary: [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-17 00:27 PDT by Zan Dobersek
Modified: 2012-09-17 23:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.83 KB, patch)
2012-09-17 11:46 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (3.27 KB, patch)
2012-09-17 13:43 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-09-17 00:27:45 PDT 
fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html is failing after introduced in r128645.
http://trac.webkit.org/changeset/128645

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-actual.txt 
@@ -1,3 +1,3 @@
 Test that DisplayImages disabled can block http image and can be reloaded in-place when toggled.
-SUCCESS
+FAILURE: Image should not be loaded when DisplayImage is unset
 

The test overrides WebKitDisplayImagesKey preference, but that's not yet supported.
Comment 1 Zan Dobersek 2012-09-17 11:46:25 PDT 
Created attachment 164428 [details]
Patch
Comment 2 Martin Robinson 2012-09-17 12:46:10 PDT 
Comment on attachment 164428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164428&action=review

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:707
> +void DumpRenderTreeSupportGtk::setLoadsImagesAutomatically(WebKitWebView* webView, bool enabled)
> +{
> +    core(webView)->settings()->setLoadsImagesAutomatically(enabled);
> +}

Why not just use the auto-load-images setting in WebKitWebSettings?
Comment 3 Zan Dobersek 2012-09-17 12:50:02 PDT 
Comment on attachment 164428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164428&action=review

>> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:707
>> +}
> 
> Why not just use the auto-load-images setting in WebKitWebSettings?

Ah, didn't see that when I was grepping. Of course, using that would be better.
Comment 4 Zan Dobersek 2012-09-17 13:43:35 PDT 
Created attachment 164449 [details]
Patch
Comment 5 Martin Robinson 2012-09-17 13:49:56 PDT 
Comment on attachment 164449 [details]
Patch

Thanks!
Comment 6 Zan Dobersek 2012-09-17 23:56:03 PDT 
Comment on attachment 164449 [details]
Patch

Clearing flags on attachment: 164449

Committed r128854: <http://trac.webkit.org/changeset/128854>
Comment 7 Zan Dobersek 2012-09-17 23:56:08 PDT 
All reviewed patches have been landed.  Closing bug.