Bug 96871 - [chromium] Add trace events to track WebGL and Accelerated Canvas creation
Summary: [chromium] Add trace events to track WebGL and Accelerated Canvas creation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-15 15:35 PDT by Vangelis Kokkevis
Modified: 2012-09-17 11:35 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.16 KB, patch)
2012-09-15 15:51 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
Patch (3.20 KB, patch)
2012-09-17 10:27 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
Patch (3.13 KB, patch)
2012-09-17 10:47 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2012-09-15 15:35:04 PDT 
Add "gpu_test" trace events that we can use to track the creation of WebGL and accelerated canvas in browser_tests. The current test we have in place that looks for SwapBuffers events won't work when we're in force-compositing-mode.
Comment 1 Vangelis Kokkevis 2012-09-15 15:51:41 PDT 
Created attachment 164297 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-16 19:17:08 PDT 
Comment on attachment 164297 [details]
Patch

Rejecting attachment 164297 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13878170
Comment 3 Vangelis Kokkevis 2012-09-17 10:27:15 PDT 
Created attachment 164412 [details]
Patch
Comment 4 WebKit Review Bot 2012-09-17 10:38:51 PDT 
Comment on attachment 164412 [details]
Patch

Rejecting attachment 164412 [details] from review queue.

vangelis@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 Vangelis Kokkevis 2012-09-17 10:47:21 PDT 
Created attachment 164417 [details]
Patch
Comment 6 WebKit Review Bot 2012-09-17 11:35:50 PDT 
Comment on attachment 164417 [details]
Patch

Clearing flags on attachment: 164417

Committed r128785: <http://trac.webkit.org/changeset/128785>
Comment 7 WebKit Review Bot 2012-09-17 11:35:53 PDT 
All reviewed patches have been landed.  Closing bug.