Bug 96853 – [chromium] DumpRenderTree support for software compositing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alexandre Elias]

[chromium] DumpRenderTree support for software compositing

[Alexandre Elias]

Created attachment 164271 [details]
Patch

[Alexandre Elias]

The expectations need some triage and bugs filed for them.  I'll do that before landing.

[WebKit Review Bot]

Comment on attachment 164271 [details]
Patch

Attachment 164271 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13844897

[Peter Beverloo (cr-android ews)]

Comment on attachment 164271 [details]
Patch

Attachment 164271 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13860253

[James Robinson]

Comment on attachment 164271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164271&action=review

> LayoutTests/ChangeLog:18
> [phone]  Alexandre Elias  <[e-mail]>

double changelogs

> LayoutTests/platform/chromium/TestExpectations:3621
> +// Render surfaces do not draw anything in the software compositor.
> +WONTFIX SKIP : platform/chromium/virtual/softwarecompositing/backface-visibility/backface-visibility-hierarchical-transform.html = IMAGE

is this really a WONTFIX? are we just going to not render reflections, etc?

[Adrienne Walker]

Comment on attachment 164271 [details]
Patch

Just FYI, you can skip entire directories in TestExpectations, e.g. 

WONTFIX SKIP : platform/chromium/virtual/softwarecompositing/reflections = IMAGE

[Alexandre Elias]

Created attachment 164466 [details]
Patch

Updated OutputDevice API and associated expectations with crbugs

[Alexandre Elias]

Created attachment 165240 [details]
Patch

Switch to new TestExpectations format and do some triage

[Alexandre Elias]

Created attachment 165451 [details]
Patch

Assign bugs to all the failing tests

[Alexandre Elias]

PTAL; this is getting more polished-looking and the Chromium-side patches have landed.

[James Robinson]

Comment on attachment 165451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165451&action=review

R=me very nice.  Sorry I left this slip through the cracks for so long.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:292
> +WebCompositorOutputSurface* WebViewHost::createOutputSurface()

ah, there's a using namespace WebKit declaration in this file that I missed. How embarrassing!

> Tools/DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp:51
> +    if (m_device.get() && size.width == m_device->width() && size.height == m_device->height())

you can just say "if (m_device &&" and let OwnPtr<T>::operator bool() do the rest

[Alexandre Elias]

Created attachment 166097 [details]
Patch

Rebase and remove .get()

[WebKit Review Bot]

Comment on attachment 166097 [details]
Patch

Clearing flags on attachment: 166097

Committed r129826: <http://trac.webkit.org/changeset/129826>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.