Bug 96853 - [chromium] DumpRenderTree support for software compositing
Summary: [chromium] DumpRenderTree support for software compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on: 96851
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-14 20:19 PDT by Alexandre Elias
Modified: 2012-09-27 17:46 PDT (History)
9 users (show)

See Also:

Attachments
Patch (32.24 KB, patch)
2012-09-14 20:28 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Patch (26.34 KB, patch)
2012-09-17 15:46 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Patch (40.91 KB, patch)
2012-09-21 19:43 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Patch (41.84 KB, patch)
2012-09-24 14:48 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Patch (40.88 KB, patch)
2012-09-27 16:56 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2012-09-14 20:19:22 PDT 
[chromium] DumpRenderTree support for software compositing
Comment 1 Alexandre Elias 2012-09-14 20:28:35 PDT 
Created attachment 164271 [details]
Patch
Comment 2 Alexandre Elias 2012-09-14 20:29:41 PDT 
The expectations need some triage and bugs filed for them.  I'll do that before landing.
Comment 3 WebKit Review Bot 2012-09-14 20:31:48 PDT 
Comment on attachment 164271 [details]
Patch

Attachment 164271 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13844897
Comment 4 Peter Beverloo (cr-android ews) 2012-09-14 20:45:06 PDT 
Comment on attachment 164271 [details]
Patch

Attachment 164271 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13860253
Comment 5 James Robinson 2012-09-16 21:52:18 PDT 
Comment on attachment 164271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164271&action=review

> LayoutTests/ChangeLog:18
> +2012-09-14  Alexandre Elias  <aelias@chromium.org>

double changelogs

> LayoutTests/platform/chromium/TestExpectations:3621
> +// Render surfaces do not draw anything in the software compositor.
> +WONTFIX SKIP : platform/chromium/virtual/softwarecompositing/backface-visibility/backface-visibility-hierarchical-transform.html = IMAGE

is this really a WONTFIX? are we just going to not render reflections, etc?
Comment 6 Adrienne Walker 2012-09-17 12:41:37 PDT 
Comment on attachment 164271 [details]
Patch

Just FYI, you can skip entire directories in TestExpectations, e.g. 

WONTFIX SKIP : platform/chromium/virtual/softwarecompositing/reflections = IMAGE
Comment 7 Alexandre Elias 2012-09-17 15:46:29 PDT 
Created attachment 164466 [details]
Patch

Updated OutputDevice API and associated expectations with crbugs
Comment 8 Alexandre Elias 2012-09-21 19:43:58 PDT 
Created attachment 165240 [details]
Patch

Switch to new TestExpectations format and do some triage
Comment 9 Alexandre Elias 2012-09-24 14:48:02 PDT 
Created attachment 165451 [details]
Patch

Assign bugs to all the failing tests
Comment 10 Alexandre Elias 2012-09-24 14:49:48 PDT 
PTAL; this is getting more polished-looking and the Chromium-side patches have landed.
Comment 11 James Robinson 2012-09-27 00:24:36 PDT 
Comment on attachment 165451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165451&action=review

R=me very nice.  Sorry I left this slip through the cracks for so long.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:292
> +WebCompositorOutputSurface* WebViewHost::createOutputSurface()

ah, there's a using namespace WebKit declaration in this file that I missed. How embarrassing!

> Tools/DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp:51
> +    if (m_device.get() && size.width == m_device->width() && size.height == m_device->height())

you can just say "if (m_device &&" and let OwnPtr<T>::operator bool() do the rest
Comment 12 Alexandre Elias 2012-09-27 16:56:33 PDT 
Created attachment 166097 [details]
Patch

Rebase and remove .get()
Comment 13 WebKit Review Bot 2012-09-27 17:46:37 PDT 
Comment on attachment 166097 [details]
Patch

Clearing flags on attachment: 166097

Committed r129826: <http://trac.webkit.org/changeset/129826>
Comment 14 WebKit Review Bot 2012-09-27 17:46:41 PDT 
All reviewed patches have been landed.  Closing bug.