Bug 96850 - [chromium] Add onSendFrameToParentCompositorAck to WebCompositorOutputSurfaceClient
Summary: [chromium] Add onSendFrameToParentCompositorAck to WebCompositorOutputSurface...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Labour
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-14 19:32 PDT by Antoine Labour
Modified: 2012-09-17 14:30 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.22 KB, patch)
2012-09-14 19:34 PDT, Antoine Labour 		no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2012-09-14 19:47 PDT, Antoine Labour 		no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2012-09-17 13:32 PDT, Antoine Labour 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Labour 2012-09-14 19:32:30 PDT 
[chromium] Add onSendFrameToParentCompositorAck to WebCompositorOutputSurfaceClient
Comment 1 Antoine Labour 2012-09-14 19:34:11 PDT 
Created attachment 164266 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-14 19:37:37 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-09-14 19:37:54 PDT 
Attachment 164266 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/Platform/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antoine Labour 2012-09-14 19:44:23 PDT 
FYI, this is needed for https://codereview.chromium.org/10915298/
Comment 5 Antoine Labour 2012-09-14 19:47:05 PDT 
Created attachment 164267 [details]
Patch
Comment 6 WebKit Review Bot 2012-09-14 20:08:44 PDT 
Comment on attachment 164267 [details]
Patch

Attachment 164267 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13850748
Comment 7 Peter Beverloo (cr-android ews) 2012-09-14 20:35:11 PDT 
Comment on attachment 164267 [details]
Patch

Attachment 164267 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13854648
Comment 8 Antoine Labour 2012-09-17 13:32:55 PDT 
Created attachment 164445 [details]
Patch
Comment 9 WebKit Review Bot 2012-09-17 14:30:51 PDT 
Comment on attachment 164445 [details]
Patch

Clearing flags on attachment: 164445

Committed r128806: <http://trac.webkit.org/changeset/128806>
Comment 10 WebKit Review Bot 2012-09-17 14:30:54 PDT 
All reviewed patches have been landed.  Closing bug.