Bug 96832 – new fast/loader tests from r128645 fail on Mac-wk2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Stephanie Lewis]

* fast/loader/display-image-unset-can-block-image-and-can-reload-in-place,html
* fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

Introduce in changeset http://trac.webkit.org/changeset/128645.

http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r128650%20(3293)/results.html

I don't believe WKTR has queueReload.

--- /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 13: TypeError: 'undefined' is not a function (evaluating 'testRunner.queueReload()')
 Test that DisplayImages disabled can block http image and can be reloaded in-place when toggled.
-SUCCESS
+FAILURE: Image should not be loaded when DisplayImage is unset

[Radar WebKit Bug Importer]

<rdar://problem/12304462>

[Bo Liu]

Is the correct fix to implement queueReload since it is used in other tests as well? eg: LayoutTests/fast/loader/reload-policy-delegate.html

[Stephanie Lewis]

most likely

[Bo Liu]

Sorry, 128645 was my first webkit patch, so I'm still getting familiar with things and will probably take awhile to implement queueReload correctly.

Can I get a sense of how urgent this is? Is there a way to temporarily mark these tests as expect crash just for mac webkit2? How are the other tests relying on queueReload handled in mac webkit2?

[Adam Barth]

Typically we just skip tests for a given port if they haven't implemented all the necessary TestRuner features.

[Stephanie Lewis]

Updated TestExpectations in http://trac.webkit.org/projects/webkit/changeset/128664.

Not incredibly urgent :).  I believe the other tests are skipped.

[Bo Liu]

Created attachment 164245 [details]
Patch

[Bo Liu]

(In reply to comment #7)
> Created an attachment (id=164245) [details]
> Patch

Ping! (Not sure if webkit-patch upload sends out email to reviewers)

[Adam Barth]

> Ping! (Not sure if webkit-patch upload sends out email to reviewers)

It does (or rather bugzilla does).

[WebKit Review Bot]

Comment on attachment 164245 [details]
Patch

Clearing flags on attachment: 164245

Committed r128676: <http://trac.webkit.org/changeset/128676>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.