Bug 96829 - Fix LoadImagesAutomatically cache behavior
Summary: Fix LoadImagesAutomatically cache behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bo Liu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-14 15:15 PDT by Bo Liu
Modified: 2012-09-17 11:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.44 KB, patch)
2012-09-14 15:18 PDT, Bo Liu
no flags Details | Formatted Diff | Diff
Add layout test that fails without this patch. Rename method to clientAllowsImage (7.39 KB, patch)
2012-09-14 19:19 PDT, Bo Liu
no flags Details | Formatted Diff | Diff
Skip new test in webkit2 since overridePreference is not supported. (8.04 KB, patch)
2012-09-14 19:29 PDT, Bo Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bo Liu 2012-09-14 15:15:59 PDT
Fix LoadImagesAutomatically cache behavior
Comment 1 Bo Liu 2012-09-14 15:18:53 PDT
Created attachment 164235 [details]
Patch
Comment 2 Adam Barth 2012-09-14 15:23:22 PDT
Comment on attachment 164235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164235&action=review

Can we add a test for this so we don't break it in the future?

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:535
> -    if (existingResource->type() == CachedResource::ImageResource && shouldDeferImageLoad(existingResource->url()))
> +    if (existingResource->type() == CachedResource::ImageResource && !clientAllowImage(existingResource->url()))

clientAllowImage -> clientAllowsImage ?
Comment 3 Bo Liu 2012-09-14 19:19:43 PDT
Created attachment 164264 [details]
Add layout test that fails without this patch. Rename method to clientAllowsImage
Comment 4 Bo Liu 2012-09-14 19:29:53 PDT
Created attachment 164265 [details]
Skip new test in webkit2 since overridePreference is not supported.
Comment 5 Adam Barth 2012-09-17 11:01:50 PDT
Comment on attachment 164265 [details]
Skip new test in webkit2 since overridePreference is not supported.

Thanks.
Comment 6 WebKit Review Bot 2012-09-17 11:19:35 PDT
Comment on attachment 164265 [details]
Skip new test in webkit2 since overridePreference is not supported.

Clearing flags on attachment: 164265

Committed r128780: <http://trac.webkit.org/changeset/128780>
Comment 7 WebKit Review Bot 2012-09-17 11:19:37 PDT
All reviewed patches have been landed.  Closing bug.