Bug 96822 - [Qt] Cleanup/refactor the user agent detection code
Summary: [Qt] Cleanup/refactor the user agent detection code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura Maranhao Neto
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-14 13:14 PDT by Lauro Moura Maranhao Neto
Modified: 2012-09-17 10:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.63 KB, patch)
2012-09-14 14:56 PDT, Lauro Moura Maranhao Neto 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2012-09-17 10:31 PDT, Lauro Moura Maranhao Neto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura Maranhao Neto 2012-09-14 13:14:12 PDT 
Followup bug after suggestions made to the original useragent patch in https://bugs.webkit.org/show_bug.cgi?id=73917
Comment 1 Lauro Moura Maranhao Neto 2012-09-14 14:56:11 PDT 
Created attachment 164231 [details]
Patch

Replaced Q_WS/Q_OS checks with WTF OS()/CPU(). Instead of Q_WS_X11, now checking QGuiApplication::platformName().
Comment 2 Simon Hausmann 2012-09-14 15:17:03 PDT 
Comment on attachment 164231 [details]
Patch

r=me. Might want to double check with the EWS before landing.
Comment 3 WebKit Review Bot 2012-09-17 09:35:27 PDT 
Comment on attachment 164231 [details]
Patch

Clearing flags on attachment: 164231

Committed r128770: <http://trac.webkit.org/changeset/128770>
Comment 4 WebKit Review Bot 2012-09-17 09:35:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Lauro Moura Maranhao Neto 2012-09-17 10:19:46 PDT 
Reopen as it broke the windows bot.
Comment 6 Lauro Moura Maranhao Neto 2012-09-17 10:31:17 PDT 
Created attachment 164413 [details]
Patch
Comment 7 WebKit Review Bot 2012-09-17 10:54:33 PDT 
Comment on attachment 164413 [details]
Patch

Clearing flags on attachment: 164413

Committed r128775: <http://trac.webkit.org/changeset/128775>
Comment 8 WebKit Review Bot 2012-09-17 10:54:36 PDT 
All reviewed patches have been landed.  Closing bug.