Bug 96802 - [Chromium] IndexedDB: Remove legacy two-phase open() API members
Summary: [Chromium] IndexedDB: Remove legacy two-phase open() API members
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-14 10:07 PDT by Joshua Bell
Modified: 2012-09-17 10:13 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.01 KB, patch)
2012-09-14 10:09 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-09-14 10:07:32 PDT 
[Chromium] IndexedDB: Remove legacy two-phase open() API members
Comment 1 Joshua Bell 2012-09-14 10:09:47 PDT 
Created attachment 164177 [details]
Patch
Comment 2 Joshua Bell 2012-09-14 10:12:04 PDT 
https://codereview.chromium.org/10916318 needs to land first.
Comment 3 Joshua Bell 2012-09-14 16:47:48 PDT 
Chromium side has landed, this is ready for review.

dgrogan@ - can you take a look?
Comment 4 WebKit Review Bot 2012-09-14 16:48:32 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 David Grogan 2012-09-14 16:48:36 PDT 
Comment on attachment 164177 [details]
Patch

LGTM
Comment 6 WebKit Review Bot 2012-09-14 17:07:27 PDT 
Comment on attachment 164177 [details]
Patch

Attachment 164177 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13851698
Comment 7 Peter Beverloo (cr-android ews) 2012-09-14 18:21:33 PDT 
Comment on attachment 164177 [details]
Patch

Attachment 164177 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13852617
Comment 8 Joshua Bell 2012-09-17 09:17:39 PDT 
I think chromium DEPS just needed to roll. Retrying the CQ.
Comment 9 WebKit Review Bot 2012-09-17 10:13:22 PDT 
Comment on attachment 164177 [details]
Patch

Clearing flags on attachment: 164177

Committed r128773: <http://trac.webkit.org/changeset/128773>
Comment 10 WebKit Review Bot 2012-09-17 10:13:26 PDT 
All reviewed patches have been landed.  Closing bug.