Bug 96791 - Web Inspector: OwnPtr and RefPtr reported by pointer can be double counted by the memory instrumentation
Summary: Web Inspector: OwnPtr and RefPtr reported by pointer can be double counted by...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-14 08:26 PDT by Yury Semikhatsky
Modified: 2012-09-17 00:43 PDT (History)
13 users (show)

See Also:

Attachments
Patch (5.80 KB, patch)
2012-09-14 08:29 PDT, Yury Semikhatsky 		apavlov: review+
apavlov: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-09-14 08:26:37 PDT 
MemoryInstrumentation::addObjectImpl(const OwnPtr<T>* const...
MemoryInstrumentation::addObjectImpl(const RefPtr<T>* const..
Should check if the smart pointer has already been visited before
counting its size.
Comment 1 Yury Semikhatsky 2012-09-14 08:29:31 PDT 
Created attachment 164160 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-09-14 08:32:37 PDT 
Comment on attachment 164160 [details]
Patch

lgtm
Comment 3 Alexander Pavlov (apavlov) 2012-09-17 00:40:06 PDT 
Comment on attachment 164160 [details]
Patch

rs=me
Comment 4 Yury Semikhatsky 2012-09-17 00:43:13 PDT 
Committed r128721: <http://trac.webkit.org/changeset/128721>