Bug 96790 – [V8] Prevent workers from calling back into other worlds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Dan Carney]

Prevent workers from calling back into other worlds

[Dan Carney]

Created attachment 164161 [details]
Patch

[Dan Carney]

trying to track down cause of this flake:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=close-code-and-reason.html

[Adam Barth]

Comment on attachment 164161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164161&action=review

> Source/WebCore/bindings/v8/WorldContextHandle.cpp:51
> +    if (v8::Context::InContext()) {
> +        v8::Handle<v8::Context> context = v8::Context::GetCurrent();
> +        if (!context.IsEmpty()) {

This is somewhat redundant.  You can skip the v8::Context::InContext() call and just test whether v8::Context::GetCurrent() returns an empty handle.

[Dan Carney]

(In reply to comment #3)
> (From update of attachment 164161 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164161&action=review
> 
> > Source/WebCore/bindings/v8/WorldContextHandle.cpp:51
> > +    if (v8::Context::InContext()) {
> > +        v8::Handle<v8::Context> context = v8::Context::GetCurrent();
> > +        if (!context.IsEmpty()) {
> 
> This is somewhat redundant.  You can skip the v8::Context::InContext() call and just test whether v8::Context::GetCurrent() returns an empty handle.

That's what I had at first, but v8 crashes on GetCurrent when not in context.

[Adam Barth]

> That's what I had at first, but v8 crashes on GetCurrent when not in context.

Really!  I didn't know that.

[WebKit Review Bot]

Comment on attachment 164161 [details]
Patch

Clearing flags on attachment: 164161

Committed r128651: <http://trac.webkit.org/changeset/128651>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.