Bug 96769 – [GTK] Don't use the C API internally in WebKitBackForwardList

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

Use the C++ classes instead.

[Carlos Garcia Campos]

Created attachment 164129 [details]
Patch

[Carlos Garcia Campos]

Created attachment 166481 [details]
Updated patch to apply on current git master

New patch in trunk broke this one

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Mario Sanchez Prada]

Comment on attachment 166481 [details]
Updated patch to apply on current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=166481&action=review

This patch is pretty straightforward and I have not much to comment here. LGTM

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:58
> +    WebBackForwardList* webList;

I would probably name it backForwardList instead of webList. But I'm not genius choosing names either, so take it as a subjective opinion.

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:140
> +WebKitBackForwardList* webkitBackForwardListCreate(WebBackForwardList* webList)

Ditto

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp:32
> +    RefPtr<WebBackForwardListItem> webListItem;

And here too. Or maybe just listItem here, not to make it too long

[Carlos Garcia Campos]

(In reply to comment #4)
> (From update of attachment 166481 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166481&action=review
> 
> This patch is pretty straightforward and I have not much to comment here. LGTM
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:58
> > +    WebBackForwardList* webList;
> 
> I would probably name it backForwardList instead of webList. But I'm not genius choosing names either, so take it as a subjective opinion.

This was wkList before, I think, I renamed to webList to avoid confusion with C API variables.

[Gustavo Noronha (kov)]

Comment on attachment 166481 [details]
Updated patch to apply on current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=166481&action=review

>>> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:58
>>> +    WebBackForwardList* webList;
>> 
>> I would probably name it backForwardList instead of webList. But I'm not genius choosing names either, so take it as a subjective opinion.
> 
> This was wkList before, I think, I renamed to webList to avoid confusion with C API variables.

How about naming it items or backForwardItems? backForwardList is a bad name I think because it's the name of the object that holds this private structure in most cases. This is the list of backForwardItems.

[Carlos Garcia Campos]

(In reply to comment #6)
> (From update of attachment 166481 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166481&action=review
> 
> >>> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:58
> >>> +    WebBackForwardList* webList;
> >> 
> >> I would probably name it backForwardList instead of webList. But I'm not genius choosing names either, so take it as a subjective opinion.
> > 
> > This was wkList before, I think, I renamed to webList to avoid confusion with C API variables.
> 
> How about naming it items or backForwardItems? backForwardList is a bad name I think because it's the name of the object that holds this private structure in most cases. This is the list of backForwardItems.

Sure!

[Carlos Garcia Campos]

Committed r131605: <http://trac.webkit.org/changeset/131605>