Bug 96759 - Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions.
Summary: Web Inspector: NMI: convert template versions of String*::reportMemoryUsage f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-14 05:19 PDT by Ilya Tikhonovsky
Modified: 2012-09-15 04:52 PDT (History)
13 users (show)

See Also:


Attachments
Patch (8.09 KB, patch)
2012-09-14 05:24 PDT, Ilya Tikhonovsky
yurys: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
for trybots (8.27 KB, patch)
2012-09-14 06:08 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-09-14 05:19:38 PDT
Initially reportMemoryUsage functions in AtomicString, WTFString and StringBuffer were template functions.
Otherwise I had to include MemoryInstrumentation.h from WebCore.
Now the core NMI code is in WTF and I can include the header and move the bodies to cpp files.
Comment 1 Ilya Tikhonovsky 2012-09-14 05:24:28 PDT
Created attachment 164113 [details]
Patch
Comment 2 Build Bot 2012-09-14 05:53:50 PDT
Comment on attachment 164113 [details]
Patch

Attachment 164113 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13855413
Comment 3 Build Bot 2012-09-14 06:01:43 PDT
Comment on attachment 164113 [details]
Patch

Attachment 164113 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13841744
Comment 4 Ilya Tikhonovsky 2012-09-14 06:08:47 PDT
Created attachment 164124 [details]
for trybots
Comment 5 Ilya Tikhonovsky 2012-09-14 07:08:08 PDT
Committed r128609: <http://trac.webkit.org/changeset/128609>