RESOLVED FIXED Bug 96759
Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions. 
https://bugs.webkit.org/show_bug.cgi?id=96759
Summary Web Inspector: NMI: convert template versions of String*::reportMemoryUsage f...
Ilya Tikhonovsky
Reported 2012-09-14 05:19:38 PDT
Initially reportMemoryUsage functions in AtomicString, WTFString and StringBuffer were template functions. Otherwise I had to include MemoryInstrumentation.h from WebCore. Now the core NMI code is in WTF and I can include the header and move the bodies to cpp files.
Attachments
Patch (8.09 KB, patch)
2012-09-14 05:24 PDT, Ilya Tikhonovsky 		yurys: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
for trybots (8.27 KB, patch)
2012-09-14 06:08 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-09-14 05:24:28 PDT
Created attachment 164113 [details] Patch
Build Bot
Comment 2 2012-09-14 05:53:50 PDT
Comment on attachment 164113 [details] Patch Attachment 164113 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13855413
Build Bot
Comment 3 2012-09-14 06:01:43 PDT
Comment on attachment 164113 [details] Patch Attachment 164113 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13841744
Ilya Tikhonovsky
Comment 4 2012-09-14 06:08:47 PDT
Created attachment 164124 [details] for trybots
Ilya Tikhonovsky
Comment 5 2012-09-14 07:08:08 PDT
Committed r128609: <http://trac.webkit.org/changeset/128609>
Note You need to log in before you can comment on or make changes to this bug.