RESOLVED FIXED Bug 96758
Web Inspector: Get rid of setting values to innerHTML in inspector front-end. 
https://bugs.webkit.org/show_bug.cgi?id=96758
Summary Web Inspector: Get rid of setting values to innerHTML in inspector front-end.
Vsevolod Vlasov
Reported 2012-09-14 05:09:25 PDT
existing occurrences: Source/WebCore/inspector/front-end/RequestHTMLView.js: iframe.contentDocument.body.innerHTML = this.request.content; This one is valid - this iframe is sandboxed. Source/WebCore/inspector/front-end/WebGLProfileView.js: this._traceLogElement.innerHTML = ""; Source/WebCore/inspector/front-end/cm/codemirror.js: // Check for problem with IE innerHTML not working when we have a Source/WebCore/inspector/front-end/cm/codemirror.js: e = new Error("A CodeMirror inside a P-style element does not work in Internet Explorer. (innerHTML bug)"); Source/WebCore/inspector/front-end/cm/codemirror.js: markerElement.innerHTML = text; Source/WebCore/inspector/front-end/cm/codemirror.js: e.innerHTML = ""; Source/WebCore/inspector/front-end/cm/codemirror.js: e.innerHTML = ""; Patch to follow
Attachments
Patch (1.49 KB, patch)
2012-09-14 05:10 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-09-14 05:10:35 PDT
Created attachment 164111 [details] Patch
WebKit Review Bot
Comment 2 2012-09-14 05:42:27 PDT
Comment on attachment 164111 [details] Patch Clearing flags on attachment: 164111 Committed r128595: <http://trac.webkit.org/changeset/128595>
WebKit Review Bot
Comment 3 2012-09-14 05:42:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.