The region of interest mechanism replaces the scrolling/zooming functionality in BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible(CaretScrollType scrollType). We accomplish this by introducing a new fine-grained setting for the various adjustment modes. Whoever enables ROI needs to disable all scroll types using the new setting. PR 208387
Created attachment 164252 [details] Patch
Comment on attachment 164252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164252&action=review > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1055 > - if (!Platform::Settings::instance()->allowCenterScrollAdjustmentForInputFields() && scrollType != EdgeIfNeeded) > + if (!(Platform::Settings::instance()->allowedScrollAdjustmentForInputFields() & scrollType)) I would name it scrollAdjustmentForInputFieldsPolicy, but this this also ok. > Source/WebKit/blackberry/WebKitSupport/InputHandler.h:71 > + enum CaretScrollType { CenterAlways = BlackBerry::Platform::Settings::ScrollAdjustmentCenterAlways, > + CenterIfNeeded = BlackBerry::Platform::Settings::ScrollAdjustmentCenterIfNeeded, > + EdgeIfNeeded = BlackBerry::Platform::Settings::ScrollAdjustmentEdgeIfNeeded }; there are compile asserts we can add to ensure these values match.
Comment on attachment 164252 [details] Patch Clearing flags on attachment: 164252 Committed r128858: <http://trac.webkit.org/changeset/128858>
All reviewed patches have been landed. Closing bug.