Bug 96745 - Create Localizer factory method for LocaleNone
Summary: Create Localizer factory method for LocaleNone
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 96351
  Show dependency tree / graph
 
Reported: 2012-09-14 03:15 PDT by yosin
Modified: 2012-09-14 04:49 PDT (History)
8 users (show)

See Also:

Attachments
Patch 1 (8.76 KB, patch)
2012-09-14 03:55 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (8.76 KB, patch)
2012-09-14 03:56 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (5.86 KB, patch)
2012-09-14 04:09 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 4 (7.11 KB, patch)
2012-09-14 04:30 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 5 (6.91 KB, patch)
2012-09-14 04:34 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-09-14 03:15:28 PDT 
Create Localizer factory method for LocaleNone.
Comment 1 yosin 2012-09-14 03:55:18 PDT 
Created attachment 164094 [details]
Patch 1
Comment 2 yosin 2012-09-14 03:56:40 PDT 
Created attachment 164095 [details]
Patch 2
Comment 3 yosin 2012-09-14 03:57:20 PDT 
Comment on attachment 164095 [details]
Patch 2

Could you review this patch?
Thanks in advance.
Comment 4 yosin 2012-09-14 04:09:34 PDT 
Created attachment 164098 [details]
Patch 3
Comment 5 Kent Tamura 2012-09-14 04:18:00 PDT 
Comment on attachment 164098 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=164098&action=review

> Source/WebCore/platform/text/LocaleNone.cpp:10
> + *     * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + *     * Redistributions in binary form must reproduce the above

Please use two-clauses version of copyright header.
Comment 6 Kent Tamura 2012-09-14 04:20:54 PDT 
Comment on attachment 164098 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=164098&action=review

> Source/WebCore/ChangeLog:16
> +        * CMakeLists.txt: Added platform/text/LocaleNone.cpp.
> +        * GNUmakefile.list.am: Added platform/text/LocaleNone.cpp
> +        * Target.pri: Added platform/text/LocaleNone.cpp.
> +        * WebCore.vcproj/WebCore.vcproj: Added platform/text/LocaleNone.cpp

We need to add Localizer.{cpp.h} too.
Comment 7 yosin 2012-09-14 04:30:47 PDT 
Created attachment 164101 [details]
Patch 4
Comment 8 yosin 2012-09-14 04:34:07 PDT 
Created attachment 164102 [details]
Patch 5
Comment 9 yosin 2012-09-14 04:43:14 PDT 
Comment on attachment 164102 [details]
Patch 5

Could you review this patch?
Thanks in advance.
Comment 10 Kent Tamura 2012-09-14 04:44:13 PDT 
Comment on attachment 164102 [details]
Patch 5

ok
Please watch the bots after landing.
Comment 11 Kent Tamura 2012-09-14 04:49:00 PDT 
Comment on attachment 164102 [details]
Patch 5

Clearing flags on attachment: 164102

Committed r128588: <http://trac.webkit.org/changeset/128588>
Comment 12 Kent Tamura 2012-09-14 04:49:05 PDT 
All reviewed patches have been landed.  Closing bug.