Bug 96744 - LocaleMac should fallback to defaultLanguage for an invalid locale
Summary: LocaleMac should fallback to defaultLanguage for an invalid locale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 96351
  Show dependency tree / graph
 
Reported: 2012-09-14 03:07 PDT by Keishi Hattori
Modified: 2012-09-14 12:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.30 KB, patch)
2012-09-14 03:22 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-09-14 03:07:48 PDT 
LocaleMac should fallback to defaultLanguage for an invalid locale
Comment 1 Keishi Hattori 2012-09-14 03:22:07 PDT 
Created attachment 164088 [details]
Patch
Comment 2 Kent Tamura 2012-09-14 03:29:13 PDT 
Comment on attachment 164088 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-09-14 03:59:34 PDT 
Comment on attachment 164088 [details]
Patch

Clearing flags on attachment: 164088

Committed r128582: <http://trac.webkit.org/changeset/128582>
Comment 4 WebKit Review Bot 2012-09-14 03:59:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Roger Fong 2012-09-14 10:09:21 PDT 
Hello,
Currently there are one of two revisions that are causing the Windows test bots to exit early after 20 crashes. This is one possible candidate. 

Do you think this could have caused a large quantity of accessibility tests on Windows 7 to start failing all of a sudden? The Windows bots have suddenly gotten into a terrible state so if you could verify this quickly I'd be greatly appreciative.

Thanks

Here are the failing tests:
accessibility/accessibility-node-memory-management.html: [object DocumentFragment]
accessibility/accessibility-node-reparent.html: [object DocumentFragment]
accessibility/accessibility-object-detached.html: [object DocumentFragment]
accessibility/adjacent-continuations-cause-assertion-failure.html: [object DocumentFragment]
accessibility/anchor-linked-anonymous-block-crash.html: [object DocumentFragment]
accessibility/anonymous-render-block-in-continuation-causes-crash.html: [object DocumentFragment]
accessibility/aria-activedescendant-crash.html: [object DocumentFragment]
accessibility/aria-checkbox-checked.html: [object DocumentFragment]
accessibility/aria-fallback-roles.html: [object DocumentFragment]
accessibility/aria-hidden-update.html: [object DocumentFragment]
accessibility/aria-hidden-updates-alldescendants.html: [object DocumentFragment]
accessibility/aria-labelledby-overrides-aria-label.html: [object DocumentFragment]
accessibility/canvas-accessibilitynodeobject.html: [object DocumentFragment]
accessibility/canvas-description-and-role.html: [object DocumentFragment]
accessibility/canvas-fallback-content.html: [object DocumentFragment]
accessibility/content-changed-notification-causes-crash.html: [object DocumentFragment]
accessibility/contenteditable-hidden-div.html: [object DocumentFragment]
accessibility/contenteditable-table-check-causes-crash.html: [object DocumentFragment]
accessibility/crash-determining-aria-role-when-label-present.html: [object DocumentFragment]
Comment 6 Roger Fong 2012-09-14 12:24:27 PDT 
The issue was fixed, thanks!