96743 – [EFL] Attempt to create a theme for 0 sized element leads to assertion hit

Bug 96743 - [EFL] Attempt to create a theme for 0 sized element leads to assertion hit

Summary: [EFL] Attempt to create a theme for 0 sized element leads to assertion hit

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit EFL (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Mikhail Pozdnyakov

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-09-14 03:06 PDT by Mikhail Pozdnyakov
Modified:	2012-09-14 12:11 PDT (History)
CC List:	8 users (show)

See Also:

Attachments
patch (3.68 KB, patch) 2012-09-14 06:39 PDT, Mikhail Pozdnyakov	no flags	Details \| Formatted Diff \| Diff
Patch (26.12 KB, patch) 2012-09-14 08:29 PDT, Rick Byers	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mikhail Pozdnyakov 2012-09-14 03:06:41 PDT

fast/selectors/querySelector-in-range-crash.html is failing with crash 

STDERR: ASSERTION FAILED: !size.isEmpty()
STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/efl/RenderThemeEfl.cpp(199) : static WebCore::RenderThemeEfl::ThemePartCacheEntry* WebCore::RenderThemeEfl::ThemePartCacheEntry::create(const WTF::String&, WebCore::FormType, const WebCore::IntSize&)
STDERR: 1   0x7fbd1289c5a7 WebCore::RenderThemeEfl::ThemePartCacheEntry::create(WTF::String const&, WebCore::FormType, WebCore::IntSize const&)
STDERR: 2   0x7fbd1289cc96 WebCore::RenderThemeEfl::getThemePartFromCache(WebCore::FormType, WebCore::IntSize const&)
STDERR: 3   0x7fbd1289d174 WebCore::RenderThemeEfl::paintThemePart(WebCore::RenderObject*, WebCore::FormType, WebCore::PaintInfo const&, WebCore::IntRect const&)
STDERR: 4   0x7fbd1289ec15 WebCore::RenderThemeEfl::paintSliderTrack(WebCore::RenderObject*, WebCore::PaintInfo const&, WebCore::IntRect const&)
STDERR: 5   0x7fbd121d57e0 WebCore::RenderTheme::paint(WebCore::RenderObject*, WebCore::PaintInfo const&, WebCore::IntRect const&)
STDERR: 6   0x7fbd120b7502 WebCore::RenderBox::paintBoxDecorations(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&)
STDERR: 7   0x7fbd1205b1f8 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&)
STDERR: 8   0x7fbd12058e12 WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&)
STDERR: 9   0x7fbd120301e7 WebCore::InlineBox::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&, WebCore::FractionalLayoutUnit, WebCore::FractionalLayoutUnit)
STDERR: 10  0x7fbd120362f3 WebCore::InlineFlowBox::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&, WebCore::FractionalLayoutUnit, WebCore::FractionalLayoutUnit)
STDERR: 11  0x7fbd121f29ab WebCore::RootInlineBox::paint(WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&, WebCore::FractionalLayoutUnit, WebCore::FractionalLayoutUnit)
STDERR: 12  0x7fbd1214e8b6 WebCore::RenderLineBoxList::paint(WebCore::RenderBoxModelObject*, WebCore::PaintInfo&, WebCore::FractionalLayoutPoint const&) const

Comment 1 Mikhail Pozdnyakov 2012-09-14 06:39:56 PDT

Created attachment 164127 [details]
patch

Comment 2 WebKit Review Bot 2012-09-14 07:00:55 PDT

Comment on attachment 164127 [details]
patch

Clearing flags on attachment: 164127

Committed r128607: <http://trac.webkit.org/changeset/128607>

Comment 3 WebKit Review Bot 2012-09-14 07:01:00 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Rick Byers 2012-09-14 08:29:16 PDT

Reopening to attach new patch.

Comment 5 Rick Byers 2012-09-14 08:29:19 PDT

Created attachment 164159 [details]
Patch

Comment 6 Chris Dumez 2012-09-14 08:30:20 PDT

(In reply to comment #5)
> Created an attachment (id=164159) [details]
> Patch

Patch seems unrelated?

Comment 7 WebKit Review Bot 2012-09-14 09:33:39 PDT

Comment on attachment 164159 [details]
Patch

Attachment 164159 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13861073

New failing tests:
fast/events/touch/gesture/gesture-tap-active-state-iframe.html

Comment 8 Rick Byers 2012-09-14 12:10:44 PDT

(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=164159) [details] [details]
> > Patch
> 
> Patch seems unrelated?

Damn, sorry.  I think maybe a bad ChangeLog merge (git merge vs. git rebase workflow mismatch with my config) caused webkit-patch to default to the wrong bug and I didn't notice.  Sorry about that.