Bug 96740 – [WK2][WKTR] TestRunner is not dumping some frame load callbacks information

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Bug 42331 added support for testrunner.dumpFrameLoadCallbacks but the callback dumping is incomplete.

At least the following dumping is missing:
"didDisplayInsecureContent"
"didRunInsecureContent"

Several test cases are skipped in WK2 because of this.

[Chris Dumez]

Created attachment 164083 [details]
Patch

[WebKit Review Bot]

Comment on attachment 164083 [details]
Patch

Rejecting attachment 164083 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 with fuzz 3.
patching file LayoutTests/platform/wk2/Skipped
Hunk #1 FAILED at 237.
Hunk #2 FAILED at 509.
2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/wk2/Skipped.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/13835954

[Chris Dumez]

Created attachment 164089 [details]
Patch for landing

Rebased on master. Could someone please cq+ ?

[WebKit Review Bot]

Comment on attachment 164089 [details]
Patch for landing

Clearing flags on attachment: 164089

Committed r128585: <http://trac.webkit.org/changeset/128585>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.